Re: pkg/54355: cmake-3.14.5 fails to build on Solaris 10

[coypu%sdf.org@localhost]

The following reply was made to PR pkg/54355; it has been noted by GNATS.

From: coypu%sdf.org@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54355: cmake-3.14.5 fails to build on Solaris 10
Date: Thu, 8 Aug 2019 07:16:10 +0000

 Patch against cmake 3.14.5 (pkgsrc-2019Q2, if that's what you are
 using). I assume you need -D_XOPEN_SOURCE=600.
 
 
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/cmake/distinfo,v
 retrieving revision 1.142
 diff -u -r1.142 distinfo
 --- distinfo	1 Jun 2019 20:24:07 -0000	1.142
 +++ distinfo	8 Aug 2019 07:13:47 -0000
 @@ -21,4 +21,4 @@
  SHA1 (patch-Source_cmAlgorithms.h) = c51cc61b1a95c07bd903363d4a04e1430e510516
  SHA1 (patch-Source_cm__string__view.hxx) = 9f2fa518d26dcaebb1e988c8027fb16456e1b80d
  SHA1 (patch-Utilities_KWIML_CMakeLists.txt) = e4bdf9fc58757e87bf7e3e3e195839eededbc796
 -SHA1 (patch-bootstrap) = 9d99cfe9f9ae826250f94bc297f5a22b8de09e84
 +SHA1 (patch-bootstrap) = 754d379171c2581cfcf2b7243ed7ecfa40f61987
 Index: patches/patch-bootstrap
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/cmake/patches/patch-bootstrap,v
 retrieving revision 1.2
 diff -u -r1.2 patch-bootstrap
 --- patches/patch-bootstrap	14 Dec 2017 22:13:34 -0000	1.2
 +++ patches/patch-bootstrap	8 Aug 2019 07:13:47 -0000
 @@ -1,10 +1,11 @@
  $NetBSD: patch-bootstrap,v 1.2 2017/12/14 22:13:34 adam Exp $
  
  Use external libuv; the one included with cmake makes building fail.
 +on SunOS, -D_XOPEN_SOURCE=600 for SA_NOCLDSTOP used in ProcessUNIX.c:2723
  
 ---- bootstrap.orig	2017-11-20 15:19:54.000000000 +0000
 +--- bootstrap.orig	2019-05-31 13:31:27.000000000 +0000
  +++ bootstrap
 -@@ -1305,11 +1306,8 @@ objs=""
 +@@ -1350,11 +1350,8 @@ objs=""
   for a in ${CMAKE_CXX_SOURCES} ${CMAKE_C_SOURCES} ${LexerParser_CXX_SOURCES} ${LexerParser_C_SOURCES} ${KWSYS_CXX_SOURCES} ${KWSYS_C_SOURCES}; do
     objs="${objs} ${a}.o"
   done
 @@ -17,7 +18,15 @@
   
   uv_c_flags=""
   if ${cmake_system_mingw}; then
 -@@ -1419,11 +1417,6 @@ for a in ${KWSYS_CXX_SOURCES}; do
 +@@ -1384,6 +1381,7 @@ else
 +       # Normally libuv uses '-D_XOPEN_SOURCE=500 -std=c90' on Solaris 5.10,
 +       # but we do not need to do that because we bootstrap using POSIX APIs.
 +       uv_c_flags="${uv_c_flags} -D__EXTENSIONS__ -D_XOPEN_SOURCE=600"
 ++      cmake_c_flags="${cmake_c_flags} -D_XOPEN_SOURCE=600"
 +       libs="${libs} -lkstat -lnsl -lsendfile -lsocket -lrt"
 +       ;;
 +   esac
 +@@ -1467,11 +1465,6 @@ for a in ${KWSYS_CXX_SOURCES}; do
     echo "${a}.o : ${src} ${dep}" >> "${cmake_bootstrap_dir}/Makefile"
     echo "	${cmake_cxx_compiler} ${cmake_cxx_flags} -DKWSYS_NAMESPACE=cmsys ${src_flags} -c ${src} -o ${a}.o" >> "${cmake_bootstrap_dir}/Makefile"
   done