pkg/54418: audio/alure bad header directory naming in PLIST under macos

[clement.bouvier.europe%gmail.com@localhost]

>Number:         54418
>Category:       pkg
>Synopsis:       audio/alure bad header directory naming  in PLIST under macos
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 28 15:35:00 +0000 2019
>Originator:     Clement Bouvier
>Release:        current
>Organization:
>Environment:
MacOS Mojave 10.14.6
>Description:
audio/alure does not use the correct directory for the header alure.h leading to PLIST error during install.
The error is also noticeable on joyent darwin pbulk build
(http://us-east.manta.joyent.com/pkgsrc/public/reports/Darwin/trunk/x86_64/20190727.1045/alure-1.2/install.log)

=> Checking file-check results for alure-1.2
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg:
ERROR:         /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg/include/AL/alure.h
ERROR: ************************************************************
ERROR: The following files are in /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg but not in the PLIST:
ERROR:         /Users/pbulk/build/audio/alure/work/.destdir/opt/pkg/include/OpenAL/alure.h
*** Error code 1
>How-To-Repeat:
install audio/alure on macosx.
>Fix:
In the top CMakeLists.txt, the relative include directory is
OpenAL not AL concerning Apple platform:

line 494:
#add an install target here
IF(APPLE)
    SET(INCPATH OpenAL)
ELSE(APPLE)
    SET(INCPATH AL)
ENDIF(APPLE)

The folowing patch adapt the PLIST consequently:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/alure/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	24 Jun 2019 10:36:50 -0000	1.2
+++ Makefile	28 Jul 2019 15:29:18 -0000
@@ -17,6 +17,14 @@
 PKGCONFIG_OVERRIDE+=	alure-static.pc.in
 PKGCONFIG_OVERRIDE+=	alure.pc.in
 
+.include "../../mk/bsd.prefs.mk"
+
+PLIST_VARS+=    alincldir
+
+.if ${OPSYS} != "Darwin"
+PLIST.alincldir=	yes
+.endif
+
 .include "options.mk"
 .include "../../audio/openal-soft/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/audio/alure/PLIST,v
retrieving revision 1.1
diff -u -r1.1 PLIST
--- PLIST	21 Sep 2018 13:24:34 -0000	1.1
+++ PLIST	28 Jul 2019 15:29:18 -0000
@@ -1,5 +1,5 @@
 @comment $NetBSD: PLIST,v 1.1 2018/09/21 13:24:34 maya Exp $
-include/AL/alure.h
+${PLIST.alincldir}include/AL/alure.h
 lib/libalure-static.a
 lib/libalure.so
 lib/libalure.so.1
Index: PLIST.Darwin
===================================================================
RCS file: PLIST.Darwin
diff -N PLIST.Darwin
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ PLIST.Darwin	28 Jul 2019 15:29:18 -0000
@@ -0,0 +1 @@
+include/OpenAL/alure.h