Re: pkg/54393: devel/gobject-introspection broken on macos (with devel/glib2 correction)

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR pkg/54393; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54393: devel/gobject-introspection broken on macos (with
 devel/glib2 correction)
Date: Tue, 23 Jul 2019 09:13:17 +0100

 On Sun, Jul 21, 2019 at 12:15:00PM +0000, clement.bouvier.europe%gmail.com@localhost wrote:
 > Moreover a previous patch by patrick Welche is removed so as to
 > make the giscanner works for the girepository.gir. The patch make
 > giscanner fails on macosx.
 
 I can't claim to be the author of the original patch, but yes,
 patch-giscanner_ccompiler.py was the one I pointed you to off-list.
 I think the idea was "no one should be altering the runtime environment".
 
 With that patch in place, we have to manually alter the MAKE_ENV by adding
 LD_LIBRARY_PATH+=${WRKSRC}/output/$PKGBASE or similar ourselves, and
 of course that won't work on macos, as the equivalent would be
 DYLD_LIBRARY_PATH or somesuch
 (http://mail-index.netbsd.org/pkgsrc-users/2019/07/19/msg029051.html)
 
 I would be happy with allowing gobject-introspection to set the
 flags itself. Maybe those with other views can speak up now?
 [Say we commit this in 10 days if no comment]
 
 I won't claim to understand the macos part, so this all looks good
 to me, apart from getting rid of the @TIMET_TYPENAME@ patches.
 time_t changed from 32-bit to 64-bit on NetBSD at some point, and
 this (at least with autoconf) did the right thing.  So, please leave
 
 devel/gobject-introspection/patches/patch-giscanner_ast.py
 devel/gobject-introspection/patches/patch-tests_scanner_Regress-1.0-expected.gir
 
 alone as time_t is irrelevant to macos.