pkg/54357: editor/ted editor does not build on macosx

[clement.bouvier.europe%gmail.com@localhost]

>Number:         54357
>Category:       pkg
>Synopsis:       editor/ted editor does not build on macosx
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 07 13:05:00 +0000 2019
>Originator:     clément bouvier
>Release:        current
>Organization:
>Environment:
macosx Mojave 10.14.5
>Description:
ted editor does not build on macosx due to undefined symbol in the final binary.

appUtil.a (generated by the package) under macosx does not include the common symbols for the build to terminate.

>How-To-Repeat:
try to build the ted editor on macosx
>Fix:
Add -c flags to ranlib.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/editors/ted/Makefile,v
retrieving revision 1.63
diff -u -r1.63 Makefile
--- Makefile	12 Mar 2018 11:16:24 -0000	1.63
+++ Makefile	7 Jul 2019 12:59:14 -0000
@@ -52,6 +52,17 @@
 
 INSTALLATION_DIRS=	bin lib/X11/app-defaults ${AFMDIR} ${INDDIR} ${INFODIR}
 
+.include "../../mk/bsd.prefs.mk"
+
+# ranlib on macos does not include common-symbol in the table of contents.
+.if ${OPSYS} == "Darwin"
+SUBST_CLASSES+=         common-symbols
+SUBST_STAGE.common-symbols=     pre-configure
+SUBST_MESSAGE.common-symbols=   include common symbol in the table of contents
+SUBST_FILES.common-symbols=     appUtil/makefile.in
+SUBST_SED.common-symbols=       -e 's,@RANLIB@,@RANLIB@ -c,g'
+.endif
+
 post-extract:
 	@cd ${WRKSRC} ; ${TOOLS_PATH.bsdtar} xf tedPackage/TedBindist.tar