pkg/54327: pulseaudio: invalid PLIST due to lirc on Arch Linux

[triaxx%NetBSD.org@localhost]

>Number:         54327
>Category:       pkg
>Synopsis:       pulseaudio: invalid PLIST due to lirc on Arch Linux
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 25 07:50:00 +0000 2019
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc (HEAD)
>Organization:
>Environment:
	
	
System: Linux guardian 5.1.9-arch1-1-ARCH #1 SMP PREEMPT Tue Jun 11 16:18:09 UTC 2019 x86_64 GNU/Linux
Architecture: x86_64
Machine: amd64
>Description:
=> Checking file-check results for pulseaudio-12.2nb5
ERROR: ************************************************************
ERROR: The following files are in /home/triaxx/netbsd/pkgsrc/audio/pulseaudio/work/.destdir/home/triaxx/pkg but not in the PLIST:
ERROR:         /home/triaxx/netbsd/pkgsrc/audio/pulseaudio/work/.destdir/home/triaxx/pkg/lib/pulse-12.0/modules/module-lirc.a
ERROR:         /home/triaxx/netbsd/pkgsrc/audio/pulseaudio/work/.destdir/home/triaxx/pkg/lib/pulse-12.0/modules/module-lirc.so
*** Error code 1
>How-To-Repeat:
cd audio/pulseaudio && bmake install
>Fix:
The following patch will be applied after the 2019Q2 freeze:

----------8<------------------8<------------------8<---------------

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/pulseaudio/Makefile,v
retrieving revision 1.135
diff -u -r1.135 Makefile
--- Makefile	23 Jun 2019 04:46:20 -0000	1.135
+++ Makefile	25 Jun 2019 07:06:07 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.135 2019/06/23 04:46:20 tsutsui Exp $
 
 DISTNAME=	pulseaudio-12.2
-PKGREVISION=	4
+PKGREVISION=	5
 CATEGORIES=	audio
 MASTER_SITES=	https://freedesktop.org/software/pulseaudio/releases/
 EXTRACT_SUFX=	.tar.xz
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/audio/pulseaudio/PLIST,v
retrieving revision 1.29
diff -u -r1.29 PLIST
--- PLIST	25 Jul 2018 12:15:59 -0000	1.29
+++ PLIST	25 Jun 2019 07:06:07 -0000
@@ -147,6 +147,8 @@
 lib/pulse-${PULSELIBVER}/modules/module-intended-roles.so
 lib/pulse-${PULSELIBVER}/modules/module-ladspa-sink.a
 lib/pulse-${PULSELIBVER}/modules/module-ladspa-sink.so
+${PLIST.lirc}/lib/pulse-${PULSELIBVER}/modules/module-lirc.a
+${PLIST.lirc}/lib/pulse-${PULSELIBVER}/modules/module-lirc.so
 lib/pulse-${PULSELIBVER}/modules/module-loopback.a
 lib/pulse-${PULSELIBVER}/modules/module-loopback.so
 lib/pulse-${PULSELIBVER}/modules/module-match.a
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/audio/pulseaudio/options.mk,v
retrieving revision 1.9
diff -u -r1.9 options.mk
--- options.mk	25 Jul 2018 12:15:59 -0000	1.9
+++ options.mk	25 Jun 2019 07:06:07 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: options.mk,v 1.9 2018/07/25 12:15:59 adam Exp $
 
 PKG_OPTIONS_VAR=	PKG_OPTIONS.pulseaudio
-PKG_SUPPORTED_OPTIONS=	avahi fftw gsettings x11
+PKG_SUPPORTED_OPTIONS=	avahi fftw gsettings lirc x11
 PKG_SUGGESTED_OPTIONS=	avahi x11
 PLIST_VARS+=		${PKG_SUPPORTED_OPTIONS}
 
@@ -14,13 +14,6 @@
 CONFIGURE_ARGS+=	--disable-avahi
 .endif
 
-.if !empty(PKG_OPTIONS:Mgsettings)
-PLIST.gsettings=	yes
-CONFIGURE_ARGS+=	--enable-gsettings
-.else
-CONFIGURE_ARGS+=	--disable-gsettings
-.endif
-
 .if !empty(PKG_OPTIONS:Mfftw)
 CONFIGURE_ARGS+=	--with-fftw
 PLIST.fftw=		yes
@@ -40,6 +33,23 @@
 CONFIGURE_ARGS+=	--without-fftw
 .endif
 
+.if !empty(PKG_OPTIONS:Mgsettings)
+PLIST.gsettings=	yes
+CONFIGURE_ARGS+=	--enable-gsettings
+.else
+CONFIGURE_ARGS+=	--disable-gsettings
+.endif
+
+.if !empty(PKG_OPTIONS:Mlirc)
+.include "../../comms/lirc/buildlink3.mk"
+.  if ${LIRC_AVAILABLE} == "yes"
+PLIST.lirc=		yes
+CONFIGURE_ARGS+=	--enable-lirc
+.  endif
+.else
+CONFIGURE_ARGS+=	--disable-lirc
+.endif
+
 .if !empty(PKG_OPTIONS:Mx11)
 .include "../../x11/libICE/buildlink3.mk"
 .include "../../x11/libSM/buildlink3.mk"

----------8<------------------8<------------------8<---------------