Re: pkg/54086: sysutils/u-boot-bananapi doesn't build with WRKOBJDIR

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54086; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/54086: sysutils/u-boot-bananapi doesn't build with WRKOBJDIR
Date: Sun, 07 Apr 2019 01:35:30 +0200

 [Sorry for the duplicate PR but I forgot to `mime -max 998' in
 order to properly render this reply to GNATS and given the last
 long lines it is probably better to resend it.]
 
 Hello YAMAMOTO, 
 
 Takashi YAMAMOTO writes:
 > [...]
 > >  >
 > >  >   CC      arch/arm/lib/asm-offsets.s
 > >  >   CHK     include/generated/asm-offsets.h
 > >  >   UPD     include/generated/asm-offsets.h
 > >  >   SHIPPED scripts/dtc/pylibfdt/libfdt.i
 > >  >   PYMOD   scripts/dtc/pylibfdt/_libfdt.so
 > >  >
 > >  > /disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.c:53:17: fatal error: fdt.h: No such file or directory
 > >  > compilation terminated.
 > >  > error: command 'cc' failed with exit status 1
 > [...]
 > here are .work.log files for both cases:
 > https://ftp.netbsd.org/pub/NetBSD/misc/yamt/pr54086/
 
 ...copypasting the interesting lines for completeness directly in the
 PR.  Without WRKOBJDIR we can see:
 
 [*] cc -fno-strict-aliasing -O2 -pthread -I/usr/include -I/usr/pkg/include -DNDEBUG -O2 -pthread -I/usr/include -I/usr/pkg/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt -fPIC -I/usr/pkg/include/python2.7 -c /disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.c -o build/temp.netbsd-8.0-amd64-2.7/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.o -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt
 <.> /disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/.gcc/bin/gcc -fno-strict-aliasing -O2 -pthread -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/.buildlink/include -DNDEBUG -O2 -pthread -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt -fPIC -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/.buildlink/include/python2.7 -c /disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.c -o build/temp.netbsd-8.0-amd64-2.7/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.o -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -D_FORTIFY_SOURCE=2 -fstack-protector
 
 ...with WRKOBJDIR:
 
 [*] cc -fno-strict-aliasing -O2 -pthread -I/usr/include -I/usr/pkg/include -DNDEBUG -O2 -pthread -I/usr/include -I/usr/pkg/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -I/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt -fPIC -I/usr/pkg/include/python2.7 -c /disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.c -o build/temp.netbsd-8.0-amd64-2.7/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.o -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -I/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt
 <.> /home/takashi/wrkobjdir/sysutils/u-boot-bananapi/work/.gcc/bin/gcc -fno-strict-aliasing -O2 -pthread -I/home/takashi/wrkobjdir/sysutils/u-boot-bananapi/work/.buildlink/include -DNDEBUG -O2 -pthread -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fPIC -I/home/takashi/wrkobjdir/sysutils/u-boot-bananapi/work/.buildlink/include/python2.7 -c /disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.c -o build/temp.netbsd-8.0-amd64-2.7/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt/fdt.o -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -D_FORTIFY_SOURCE=2 -fstack-protector
 
 Doing a `tr ' ' '\n'' and diff(1)ing them shows that - apart the
 different paths used - but that should be okay - the with WRKOBJDIR case
 misses the following -I that is present in without WRKOBJDIR (when
 consumed by the wrappers, i.e. the `<.>' line):
 
  -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt
 
 (But unfortunately I have no idea ATM why:
 
  -I/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.11/scripts/dtc/libfdt
 
 ...isn't passed to the wrappers as well, sorry.)