Re: pkg/53934: shells/fish could use a `doc' option to make building documentation with doxygen optional

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/53934; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53934: shells/fish could use a `doc' option to make building documentation with doxygen optional
Date: Mon, 04 Feb 2019 21:19:49 +0100

 Hello Dean,
 
 bapabooiee%gmail.com@localhost writes:
 > [...]
 > >Description:
 > Right now shells/fish requires devel/doxygen as a BUILD_DEPEND, and thus=
  pulls in a lot of other dependencies (e.g. perl, python, graphviz, ghosts=
 cript, etc.) that all take quite a while to build, especially on slower pl=
 atform. And from my experiences, these dependencies tend to hit build erro=
 rs on other platforms such as Linux or macOS.
 >
 > It'd be nice if there was a `doc' flag to make pulling-in doxygen and fr=
 iends optional, since most users probably don't want to wait for all of th=
 at stuff when they just want to start using their preferred shell.
 > [...]
 
 Would you like to work at it? :)
 
 I think that a lot of inspiration can be taken, for example, by
 looking at devel/cppunit:
 
  - Create an options.mk (probably the one from cppunit can be just
    copypasted except for needing an adjustment in PKG_OPTIONS_VAR and
    maybe in CONFIGURE_ARGS!)
    According a `cvs log' it seems that doxygen was required on
    purpose so it is probably better to add the `doc' option to
    PKG_SUGGESTED_OPTIONS.
  - Add `.include "options.mk"' in Makefile and remove the
    `BUILD_DEPENDS+=3Ddoxygen-[0-9]*:../../devel/doxygen' line there.
  - Try to rebuild it and install with
    `env PKG_OPTIONS.fish=3D-doc make install', if everything worked there
    will be probably a big PLIST mismatch!  For all the mismatched
    entries please add a leading `${PLIST.doc}' line.
 
 
 Thank you!