pkg/53761: pkgsrc/chat/quirc runtime errors

[scole_mail%gmx.com@localhost]

>Number:         53761
>Category:       pkg
>Synopsis:       pkgsrc/chat/quirc runtime errors
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 03 02:35:00 +0000 2018
>Originator:     scole_mail
>Release:        pkgsrc-2018Q3
>Organization:
none
>Environment:
NetBSD dstar 8.0_STABLE NetBSD 8.0_STABLE (GENERIC) #0: Fri Nov 30 13:53:15 PST 2018  scole@dstar:/home/scole/nbsd/cvs/8_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
pkgsrc/chat/quirc will build fine for me, but the first time running it I these errors, one is in a tcl pop-up window, and the other is displayed in the terminal:

Error: File: quirc.cc Line: 90

File: quirc.cc Line: 90
couldn't read file "/usr/pkg/share/quirc/common/install.tcl": no such file or directory
    while executing
"source $DATADIR/common/install.tcl"

ERROR Info:
couldn't read file "/home/scole/.quirc/global.tcl": no such file or directory
    while executing
"source $env(HOME)/.quirc/global.tcl"
ERROR Code: POSIX ENOENT {no such file or directory}
ERROR Additional Info: File: quirc.cc Line: 222

It seems the program is looking for 
     pkg/share/quirc/themes/default.tcl
     pkg/share/quirc/common/install.tcl
instead of where they get installed in 
    pkg/share/quirc/default.tcl
    pkg/share/quirc/install.tcl

I've included a set of patches below to that seems to allow the program to start up and run, though it does core dump sometimes.  Maybe there are some configure, pkgsrc-makefile, or tk patches that would be a better way to go...

Sorry I don't have pkgsrc-current installed, but I think it is the same version in pkgsrc-2018Q3.

Thanks


>How-To-Repeat:
install pkgsrc/chat/quirc

run quirc for the first time
>Fix:

Summary of changes:  (A/? = New, R/D = Removed, M = Modified)
=============================================================
M Makefile
M PLIST

Apply patch with "cd .../pkgsrc/chat/quirc ; patch -s -p0 < .../patchfile"

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/chat/quirc/Makefile,v
retrieving revision 1.30
diff -b -u -r1.30 Makefile
--- Makefile	4 Jul 2018 13:40:11 -0000	1.30
+++ Makefile	3 Dec 2018 02:01:45 -0000
@@ -2,7 +2,7 @@
 #
 
 DISTNAME=	quirc-0.9.84
-PKGREVISION=	9
+PKGREVISION=	10
 CATEGORIES=	chat
 #MASTER_SITES=	http://quirc.org/
 
@@ -26,9 +26,22 @@
 SUBST_SED.T86+=		-e 's,8.3,8.6,g'
 SUBST_SED.T86+=		-e 's,83,86,g'
 
+INSTALLATION_DIRS=	bin
+INSTALLATION_DIRS+=	share/doc/quirc
+INSTALLATION_DIRS+=	share/quirc
+INSTALLATION_DIRS+=	share/quirc/common
+INSTALLATION_DIRS+=	share/quirc/themes
+
 pre-configure:
 	cd ${WRKSRC} && autoreconf -i
 
+# XXX move default.tcl to themes/default.tcl and install to common/install.tcl
+post-install:
+	${MV} ${DESTDIR}${PREFIX}/share/quirc/default.tcl \
+		${DESTDIR}${PREFIX}/share/quirc/themes
+	${MV} ${DESTDIR}${PREFIX}/share/quirc/install.tcl \
+		${DESTDIR}${PREFIX}/share/quirc/common
+
 BUILDLINK_DEPMETHOD.libXt?=	build
 
 CPPFLAGS+=	-DUSE_INTERP_RESULT
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/chat/quirc/PLIST,v
retrieving revision 1.3
diff -b -u -r1.3 PLIST
--- PLIST	14 Jun 2009 17:37:49 -0000	1.3
+++ PLIST	3 Dec 2018 02:01:47 -0000
@@ -14,13 +14,13 @@
 share/doc/quirc/rfc1459.txt
 share/quirc/VERSION
 share/quirc/dal.tcl
-share/quirc/default.tcl
+share/quirc/themes/default.tcl
 share/quirc/doc.tcl
 share/quirc/fontsel
 share/quirc/fun.tcl
 share/quirc/global.tcl
 share/quirc/info.tcl
-share/quirc/install.tcl
+share/quirc/common/install.tcl
 share/quirc/listfile.tcl
 share/quirc/mircservers.tcl
 share/quirc/newserver.tcl