[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/50776 CVS commit: src/sys/kern
The following reply was made to PR pkg/50776; it has been noted by GNATS.
From: "SAITOH Masanobu" <msaitoh%netbsd.org@localhost>
Subject: PR/50776 CVS commit: src/sys/kern
Date: Thu, 2 Aug 2018 04:28:56 +0000
Module Name: src
Committed By: msaitoh
Date: Thu Aug 2 04:28:56 UTC 2018
Adjust alignment in m_pulldown().
IP6_EXTHDR_GET() and M_REGION_GET() do m_pulldown(). When m_pulldown() copies
data into M_TRAILINGSPACE, the alignment might be changed. There are a lot of
IP6_EXTHDR_GET() calls, so I think it's not good to check the alignment after
every IP6_EXTHDR_GET() call. This change fixes this problem in m_pulldown().
In this commit, the next mbuf are 4 byte aligned. For networking, I've never
heard that 64bit alignment is required, so I think it would be OK.
I don't know this is the best solution, but it's better than nothing.
OK'd by maxv@.
After committing this change, the workaround code for PR#50776 can be removed.
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/kern/uipc_mbuf2.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |