Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails

[Kamil Rytarowski <n54%gmx.com@localhost>]

The following reply was made to PR pkg/53240; it has been noted by GNATS.

From: Kamil Rytarowski <n54%gmx.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
Date: Wed, 23 May 2018 08:03:00 +0200

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
 Content-Type: multipart/mixed; boundary="Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts";
  protected-headers="v1"
 From: Kamil Rytarowski <n54%gmx.com@localhost>
 To: gnats-bugs%NetBSD.org@localhost
 Message-ID: <777622d4-ecc7-21ae-cb0a-25fe5da48ac4%gmx.com@localhost>
 Subject: Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails
 References: <20180522234116.GA21971%nyx.net@localhost>
 In-Reply-To: <20180522234116.GA21971%nyx.net@localhost>
 
 --Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts
 Content-Type: text/plain; charset=utf-8
 Content-Language: en-US
 Content-Transfer-Encoding: quoted-printable
 
 On 23.05.2018 01:41, Roy Bixler wrote:
 > On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
 >> The patch is just wrong.
 >=20
 > That's unfortunate, but I'm not surprised.  After all, I don't know
 > how to test whether it works and I had no prior confirmation that it
 > was supposed to work.  It did make vlc buildable for me.  I also
 > mentioned another possible patch from
 >=20
 > https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html
 >=20
 > I'll repeat it here:
 >=20
 > --- modules/codec/x264.c.orig	2015-04-13 19:54:35.000000000 +0000
 > +++ modules/codec/x264.c
 > @@ -843,7 +843,7 @@ static int  Open ( vlc_object_t *p_this=20
 >      fullrange =3D var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
 >      p_enc->fmt_in.i_codec =3D fullrange ? VLC_CODEC_J420 : VLC_CODEC_I=
 420;
 >      p_sys->i_colorspace =3D X264_CSP_I420;
 > -#if X264_BUILD >=3D 118
 > +#if X264_BUILD >=3D 118 && X264_BUILD < 155
 >      char *psz_profile =3D var_GetString( p_enc, SOUT_CFG_PREFIX "profi=
 le" );
 >      if( psz_profile )
 >      {
 >=20
 > This is much simpler.  Is it also wrong?  If so, do you have an
 > alternative?
 >=20
 
 This approach was rejected upstream so it's presumably wrong.
 
 Can you use VLC 3.x? It's in pkgsrc/wip/vlc.
 
 It crashes for me due to X issues, but it might works for you.
 
 
 --Lkx7eBLwEqiZSryhBIgbOWRz9rhPl3wts--
 
 --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 
 iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlsFBBQMHG41NEBnbXgu
 Y29tAAoJEEuzCOmwLnZsPpEP/RoH3vo7EYNj8x0lzAbSrxGO0nFfy41nb8PdmEAb
 J1vm2wgSJMGSB8gEsIdTgkUPUsmGO4vXbdgztmLFGbzc5VmtxtvsXa0cx1OPwfjA
 5Rrhk6Mti461AokqbbWvKCxuNfkVb5L83JL61Vd0aR0KcEHibFT7wsWcYZZksCmi
 sXqcdKiodvn5ctujNpisDbqStJC1IsPFwtN3A6FLYZhfvdWgD6IBCDuypCjC7YHs
 7PJSkGWabDoPydajUBMMQDYBM6WXW0eOn+K2XXj8q5Dt5UG5PN78x51ln+z/LQQb
 ke42Zaubat19dGL4JZUfD2Qoqb9FI4kAtKcQMtXK5KXfCapsgHCcarsZG8vf7LgG
 Vc+ukU8EAUk3K0kc0bBWlkoi0vuviJQuEXNScVd6M2L6yLjoga5Kh1oK6vzUAqlI
 MGDf11U/Cq8POAeu+TmaeLURWvdbhxJMbgYv1K0r2GGKkaLrcsJYqsGxhVtC/Xr5
 LWwBhhppMdb0GDsgTaWAewnGdNq+n9X/okqJAjmJfBL1S4ZmNoj4S8XRSqI9RZGM
 W82F/ps0z2YjN2kxgTqlxXLFDro6YNVLsvFr4vycF5ZS+ZJCiOdVcLoN6CkFLg6f
 +Ta8PMbmKHMpQ4Zwt0lY7n83bEooWKBXIDVeT6IP+8wGzQcR1EJdbDhN/q8XJITR
 aDPT
 =wqDK
 -----END PGP SIGNATURE-----
 
 --zzYpHE2ZDLy8zliaNAscLBGFVuVzUlZ9M--