Re: pkg/53063: USE_PKGLOCALEDIR broken?

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/53063; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53063: USE_PKGLOCALEDIR broken?
Date: Fri, 02 Mar 2018 08:48:36 +0100

 Le 2018-03-02 00:50, Thomas Klausner a écrit :
 > The following reply was made to PR pkg/53063; it has been noted by 
 > GNATS.
 > 
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > Cc:
 > Subject: Re: pkg/53063: USE_PKGLOCALEDIR broken?
 > Date: Fri, 2 Mar 2018 00:45:08 +0100
 > 
 >  That's a misunderstanding. The PLIST always has share/locale, this is
 > automatically fixed.
 > 
 >  Compare PKGMANDIR, the PLIST always has man/manX for that too.
 >   Thomas
 
 Yes, I misunderstood USE_PKGLOCALEDIR because the PLIST of wip/lightdm 
 contained some lines like 
 ${PKGLOCALEDIR}/locale/af/LC_MESSAGES/lightdm.mo and its Makefile 
 explicitly declared USE_PKGLOCALDIR=yes.
 
 Since (1) a package is built for a given system and (2) PKGLOCALEDIR is 
 not a public configuration variable, ${PKGLOCALDIR} in PLIST seems 
 useless.
 
 According to mk/configure/replace-localedir.mk:
 ######################################################################
 ### replace-localedir (PRIVATE)
 ######################################################################
 [...]
 .if empty(USE_PKGLOCALEDIR:M[nN][oO])
 SUBST_CLASSES+=     pkglocaledir
 .endif
 
 Hence, I would remove the line 'USE_PKGLOCALDIR=yes' that sounds 
 confusing to me.