pkg/52921: cross/cross-libtool-base/PLIST is broken

[Harold Gutch <logix%foobar.franken.de@localhost>]

>Number:         52921
>Category:       pkg
>Synopsis:       cross/cross-libtool-base/PLIST is broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 12 23:30:00 +0000 2018
>Originator:     Harold Gutch
>Release:        pkgsrc HEAD
>Organization:
>Environment:
NetBSD  7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
On March 10, 2017, devel/libtool-base (and a few accompanying packages in devel) were updated from libtool 2.4.2 to libtool 2.4.6 and this change came with an update to PLIST.  cross/cross-libtool-base (which pulls in devel/libtool/Makefile) never got updated to this new PLIST, and and as a result, "make {install,package}" fails for cross-libtool-base:

=> Generating post-install file lists
pkg_create: can't stat `/usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg/cross/share/aclocal/argz.m4'
[...]
pkg_create: can't stat `/usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg/cross/share/libtool/libltdl/slist.c'
=> Checking file-check results for cross-libtool-base-x86_64-2.4.6nb4
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg:
ERROR:         /usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg/cross/share/aclocal/argz.m4
[...]
ERROR: ************************************************************
ERROR: The following files are in /usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg but not in the PLIST:
ERROR:         /usr/pkgsrc/cross/cross-libtool-base/work/.destdir/usr/pkg/cross/share/aclocal/ltargz.m4 
[...]
>How-To-Repeat:
cd ${PKGSRC}/cross/cross-libtool-base
make package
>Fix:
Apply this patch:

--- cross/cross-libtool-base/PLIST.orig	2016-06-19 16:19:04.000000000 +0000
+++ cross/cross-libtool-base/PLIST	2018-01-12 15:16:15.000000000 +0000
@@ -4,52 +4,52 @@
 cross/bin/shlibtool
 cross/man/man1/libtool.1
 cross/man/man1/libtoolize.1
-cross/share/aclocal/argz.m4
 cross/share/aclocal/libtool.m4
+cross/share/aclocal/ltargz.m4
 cross/share/aclocal/ltdl.m4
 cross/share/aclocal/ltoptions.m4
 cross/share/aclocal/ltsugar.m4
 cross/share/aclocal/ltversion.m4
 cross/share/aclocal/lt~obsolete.m4
-cross/share/libtool/config/compile
-cross/share/libtool/config/config.guess
-cross/share/libtool/config/config.sub
-cross/share/libtool/config/depcomp
-cross/share/libtool/config/install-sh
-cross/share/libtool/config/ltmain.sh
-cross/share/libtool/config/missing
-cross/share/libtool/libltdl/COPYING.LIB
-cross/share/libtool/libltdl/Makefile.am
-cross/share/libtool/libltdl/Makefile.in
-cross/share/libtool/libltdl/Makefile.inc
-cross/share/libtool/libltdl/README
-cross/share/libtool/libltdl/aclocal.m4
-cross/share/libtool/libltdl/argz.c
-cross/share/libtool/libltdl/argz_.h
-cross/share/libtool/libltdl/config-h.in
-cross/share/libtool/libltdl/configure
-cross/share/libtool/libltdl/configure.ac
-cross/share/libtool/libltdl/libltdl/lt__alloc.h
-cross/share/libtool/libltdl/libltdl/lt__dirent.h
-cross/share/libtool/libltdl/libltdl/lt__glibc.h
-cross/share/libtool/libltdl/libltdl/lt__private.h
-cross/share/libtool/libltdl/libltdl/lt__strl.h
-cross/share/libtool/libltdl/libltdl/lt_dlloader.h
-cross/share/libtool/libltdl/libltdl/lt_error.h
-cross/share/libtool/libltdl/libltdl/lt_system.h
-cross/share/libtool/libltdl/libltdl/slist.h
-cross/share/libtool/libltdl/loaders/dld_link.c
-cross/share/libtool/libltdl/loaders/dlopen.c
-cross/share/libtool/libltdl/loaders/dyld.c
-cross/share/libtool/libltdl/loaders/load_add_on.c
-cross/share/libtool/libltdl/loaders/loadlibrary.c
-cross/share/libtool/libltdl/loaders/preopen.c
-cross/share/libtool/libltdl/loaders/shl_load.c
-cross/share/libtool/libltdl/lt__alloc.c
-cross/share/libtool/libltdl/lt__dirent.c
-cross/share/libtool/libltdl/lt__strl.c
-cross/share/libtool/libltdl/lt_dlloader.c
-cross/share/libtool/libltdl/lt_error.c
-cross/share/libtool/libltdl/ltdl.c
-cross/share/libtool/libltdl/ltdl.h
-cross/share/libtool/libltdl/slist.c
+cross/share/libtool/COPYING.LIB
+cross/share/libtool/Makefile.am
+cross/share/libtool/Makefile.in
+cross/share/libtool/README
+cross/share/libtool/aclocal.m4
+cross/share/libtool/build-aux/compile
+cross/share/libtool/build-aux/config.guess
+cross/share/libtool/build-aux/config.sub
+cross/share/libtool/build-aux/depcomp
+cross/share/libtool/build-aux/install-sh
+cross/share/libtool/build-aux/ltmain.sh
+cross/share/libtool/build-aux/missing
+cross/share/libtool/config-h.in
+cross/share/libtool/configure
+cross/share/libtool/configure.ac
+cross/share/libtool/libltdl/lt__alloc.h
+cross/share/libtool/libltdl/lt__argz_.h
+cross/share/libtool/libltdl/lt__dirent.h
+cross/share/libtool/libltdl/lt__glibc.h
+cross/share/libtool/libltdl/lt__private.h
+cross/share/libtool/libltdl/lt__strl.h
+cross/share/libtool/libltdl/lt_dlloader.h
+cross/share/libtool/libltdl/lt_error.h
+cross/share/libtool/libltdl/lt_system.h
+cross/share/libtool/libltdl/slist.h
+cross/share/libtool/loaders/dld_link.c
+cross/share/libtool/loaders/dlopen.c
+cross/share/libtool/loaders/dyld.c
+cross/share/libtool/loaders/load_add_on.c
+cross/share/libtool/loaders/loadlibrary.c
+cross/share/libtool/loaders/preopen.c
+cross/share/libtool/loaders/shl_load.c
+cross/share/libtool/lt__alloc.c
+cross/share/libtool/lt__argz.c
+cross/share/libtool/lt__dirent.c
+cross/share/libtool/lt__strl.c
+cross/share/libtool/lt_dlloader.c
+cross/share/libtool/lt_error.c
+cross/share/libtool/ltdl.c
+cross/share/libtool/ltdl.h
+cross/share/libtool/ltdl.mk
+cross/share/libtool/slist.c