Re: pkg/52575: audacious-plugins fails packaging w/o "jack" option

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

The following reply was made to PR pkg/52575; it has been noted by GNATS.

From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/52575: audacious-plugins fails packaging w/o "jack" option
Date: Wed, 27 Sep 2017 10:21:04 -0500 (CDT)

 Attempting to force the issue by adding:
 
 .if "${PKGPATH}" == "audio/audacious-plugins"
   CONFIGURE_ARGS+=      --enable-resample
   CONFIGURE_ARGS+=      --enable-speedpitch
 .endif
 
 to "/etc/mk.conf", causes configuration to fail because it claims not
 to detect "libsamplerate":
 
 [...]
 checking for SAMPLERATE... no
 configure: error: Cannot find libsamplerate development files, but compilation of resample effect plugin has been explicitly requested; please install libsamplerate dev files and run configure again
 *** Error code 1
 
 Stop.
 make[1]: stopped in /x/pkgsrc/audio/audacious-plugins
 *** Error code 1
 
 Stop.
 make: stopped in /x/pkgsrc/audio/audacious-plugins
 
 
 "libsamplerate" is installed (dependency of "audacious" and "sox" as
 well as "jack").
 
 The following patch allows it to work properly:
 
 +Index: audio/audacious-plugins/Makefile
 +===================================================================
 +RCS file: /cvsroot/pkgsrc/audio/audacious-plugins/Makefile,v
 +retrieving revision 1.73
 +diff -u -p -r1.73 Makefile
 +--- audio/audacious-plugins/Makefile	8 Sep 2017 02:38:36 -0000	1.73
 ++++ audio/audacious-plugins/Makefile	27 Sep 2017 15:17:59 -0000
 +@@ -84,6 +84,7 @@ PLIST.oss=	yes
 + .include "../../audio/libmpcdec/buildlink3.mk"
 + .include "../../audio/libsndfile/buildlink3.mk"
 + .include "../../audio/libvorbis/buildlink3.mk"
 ++.include "../../audio/libsamplerate/buildlink3.mk"
 + .include "../../audio/mpg123/buildlink3.mk"
 + .include "../../audio/taglib/buildlink3.mk"
 + .include "../../audio/wavpack/buildlink3.mk"
 
 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645