Re: pkg/52444: security/libgcrypt 1.8.0 fails to build on evbarmv6hf (Raspberry Pi B+)

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/52444; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/52444: security/libgcrypt 1.8.0 fails to build on evbarmv6hf (Raspberry Pi B+)
Date: Mon, 31 Jul 2017 11:11:24 +0200

 Hello Marek,
 
 dusxmt%gmx.com@localhost writes:
 > >Number:         52444
 > >Category:       pkg
 > >Synopsis:       security/libgcrypt 1.8.0 fails to build on evbarmv6hf (=
 Raspberry Pi B+)
 > >Confidential:   no
 > >Severity:       critical
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Mon Jul 31 07:50:00 +0000 2017
 > >Originator:     Marek Benc
 > >Release:        Current pkgsrc, 31. 7. 2017
 > >Organization:
 > >Environment:
 > NetBSD dooshki-raspi.homenetwork 7.1 NetBSD 7.1 (RPI.201703111743Z) evba=
 rm
 > >Description:
 > My machine fails to upgrade security/libgcrypt from 1.7.7 to 1.8.0.
 > =
 
 > It appears that it attempts to build some code hand-optimized for ARMv8 =
 (configure refers to it as "Try using ARMv8 crypto:    yes"), but my machi=
 ne is ARMv6, and the compiler catches it and aborts because of it.
 > =
 
 > [...]
 > config.status: executing gcrypt-conf commands
 >          =
 
 >         Libgcrypt v1.8.0 has been configured as follows:
 >          =
 
 >         Platform:                  NetBSD (armv6--netbsdelf-eabihf)
 >         Hardware detection module: hwf-arm
 > [...]
 >         Try using Intel AVX:       n/a
 >         Try using Intel AVX2:      n/a
 >         Try using ARM NEON:        yes
 >         Try using ARMv8 crypto:    yes
 >
 
 Can you please try the following patch?:
 
  https://www.NetBSD.org/~leot/pkgsrc-patches/libgcrypt-pkg52444.patch
 
 Also attached here in-line:
 
 -----------------8<-----------------8<-----------------8<-----------------
 Disable NEON and ARMv8 optimizations.
 
 Should address PR pkg/52444 reported by Marek Benc.
 
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/security/libgcrypt/Makefile,v
 retrieving revision 1.91
 diff -u -p -r1.91 Makefile
 --- Makefile	23 Jul 2017 17:27:52 -0000	1.91
 +++ Makefile	31 Jul 2017 09:02:53 -0000
 @@ -54,6 +54,11 @@ CONFIGURE_ENV+=3D		gcry_cv_gcc_inline_asm_
  .  endif
  .endif
  =
 
 +.if ${MACHINE_ARCH} =3D=3D "arm"
 +CONFIGURE_ARGS+=3D	--disable-neon-support
 +CONFIGURE_ARGS+=3D	--disable-arm-crypto-support
 +.endif
 +
  SUBST_CLASSES+=3D		rpath
  SUBST_FILES.rpath=3D	src/libgcrypt-config.in
  SUBST_STAGE.rpath=3D	pre-configure