Re: pkg/51970: Ethernet (libpcap) support not compiled in

[Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>]

The following reply was made to PR pkg/51970; it has been noted by GNATS.

From: Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, coypu%SDF.ORG@localhost, hans%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/51970: Ethernet (libpcap) support not compiled in
Date: Thu, 16 Feb 2017 22:05:51 +0900

 On 2017/02/16 8:05, coypu%SDF.ORG@localhost wrote:
 >  Hmm, on my end it tries to open /dev/bpf and complains about
 >  permissions - does it really require root? seems excessive.
 
 It requires the read and write permissions of /dev/bpf when it uses
 the Berkeley packet filter... Maya, I must say, please do not commit
 anything you cannot test by yourself (although I really appreciate
 your contributions to NetBSD).
 
 Anyway, It seems that environment variables INCLUDES and LIBRARIES
 confuse simh to fail to detect what libraries we have. By reverting
 partially Makefile r1.44 (and r1.45), I obtained binaries with
 working network support on NetBSD. But these environment variables
 are necessary for other platforms? Hans, how do you think about it?
 
 Thanks,
 rin
 
 Index: Makefile
 ===================================================================
 RCS file: /cvs/cvsroot/pkgsrc/emulators/simh/Makefile,v
 retrieving revision 1.45
 diff -u -r1.45 Makefile
 --- Makefile	15 Feb 2017 01:27:00 -0000	1.45
 +++ Makefile	16 Feb 2017 12:44:28 -0000
 @@ -2,7 +2,7 @@
   
   DISTNAME=	simh-4.0.0
   PKGNAME=	simh-4.0.0.20161218
 -PKGREVISION=	1
 +PKGREVISION=	2
   CATEGORIES=	emulators
   MASTER_SITES=	${MASTER_SITE_GITHUB:=simh/}
   GITHUB_PROJECT=	simh
 @@ -33,24 +33,9 @@
   CFLAGS.SunOS+=	-DBSD_COMP
   LDFLAGS.SunOS+=	-lm
   
 -CFLAGS+=		-DUSE_NETWORK
 -LDFLAGS+=		-lpcap
 -
   INSTALLATION_DIRS=	bin share/simh share/doc/simh
   
   MAKE_FILE=		makefile
 -INCLUDES=		${PREFIX:Q}/include:\
 -			${BUILDLINK_PREFIX.SDL_ttf:Q}/include/SDL:\
 -			${BUILDLINK_PREFIX.libpcap:Q}/include/pcap:\
 -			${BUILDLINK_PREFIX.pcre:Q}/include/pcre:\
 -			${BUILDLINK_PREFIX.png:Q}/include
 -LIBRARIES=		${PREFIX:Q}/lib:\
 -			${BUILDLINK_PREFIX.SDL_ttf:Q}/lib${LIBABISUFFIX}:\
 -			${BUILDLINK_PREFIX.libpcap:Q}/lib${LIBABISUFFIX}:\
 -			${BUILDLINK_PREFIX.pcre:Q}/lib${LIBABISUFFIX}:\
 -			${BUILDLINK_PREFIX.png:Q}/lib${LIBABISUFFIX}
 -MAKE_ENV+=		INCLUDES=${INCLUDES:Q}
 -MAKE_ENV+=		LIBRARIES=${LIBRARIES:Q}
   MAKE_ENV+=		GCC=${CC:Q}
   MAKE_ENV+=		OS_LDFLAGS=${LDFLAGS:Q} CFLAGS_O=${CFLAGS:Q}