pkg/51947: more pkgsrc sqlite3 features for firefox

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         51947
>Category:       pkg
>Synopsis:       more pkgsrc sqlite3 features for firefox
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 05 12:50:00 +0000 2017
>Originator:     Izumi Tsutsui
>Release:        NetBSD 7.1_RC1 + pkgsrc-2016Q4
>Organization:
>Environment:
System: NetBSD mirage 7.1_RC1 NetBSD 7.1_RC1 (GENERIC.201701060741Z) i386
Architecture: i386
Machine: i386
>Description:
Currently www/firefox use internal sqlite3 instead of pkgsrc sqlite3,
probably because pkgsrc one does not enable features
(SQLITE_SECURE_DELETE and SQLITE_ENABLE_DBSTAT_VTAB)
required by firefox. It would be worth to enable them in pkgsrc sqlite3.

Per "Compile-time Options" document https://www.sqlite.org/compile.html
SQLITE_SECURE_DELETE is in "Options To Control Operating Characteristics"
and SQLITE_ENABLE_DBSTAT_VTAB is in "Options To Enable Features Normally
Turned Off."

I'm not sure if these options affect other packages that depend on
pkgsrc sqlite3, though.

>How-To-Repeat:
N/A (change request)

>Fix:
pkgsrc/database/sqlite3 (3.16.2 in HEAD) with the following patch allows
firefox builds with --enable-system-sqlite.

(BTW py-sqlite2 and other python version definitions in mozilla-common.mk
 seem obsolete)

Other packages that refer common sqlite3/Makefile.version might also
want PKGREVISION bump.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/databases/sqlite3/Makefile,v
retrieving revision 1.113
diff -u -p -r1.113 Makefile
--- Makefile	2 Jan 2017 17:52:23 -0000	1.113
+++ Makefile	5 Feb 2017 12:10:15 -0000
@@ -5,6 +5,7 @@
 .include "Makefile.common"
 
 PKGNAME=	sqlite3-${SQLITE3_VERSION}
+PKGREVISION=	1
 CATEGORIES=	databases
 
 MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
@@ -36,6 +37,9 @@ CFLAGS+=		-DSQLITE_ENABLE_LOCKING_STYLE=
 # This define includes the sqlite3_unlock_notify() API in the build.
 # It is required by Firefox 4.x.
 CFLAGS+=		-DSQLITE_ENABLE_UNLOCK_NOTIFY=1
+# Firefox requires SECURE_DELETE and DBSTAT_VTAB.
+CFLAGS+=		-DSQLITE_SECURE_DELETE
+CFLAGS+=		-DSQLITE_ENABLE_DBSTAT_VTAB
 # The following are defined in the NetBSD builtin version.
 CFLAGS+=		-DSQLITE_ENABLE_COLUMN_METADATA
 CFLAGS+=		-DSQLITE_ENABLE_LOAD_EXTENSION