pkg/51696: INDEX generation problems

[amdmi3%amdmi3.ru@localhost]

>Number:         51696
>Category:       pkg
>Synopsis:       INDEX generation problems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 07 10:10:00 +0000 2016
>Originator:     Dmitry Marakasov
>Release:        
>Organization:
>Environment:
>Description:
pkgsrc INDEX is broken in at least two places.

1. net/p5-IO-Socket-INET6 has incorrect number of fields due to "|" in COMMENT field:

% cat INDEX|awk -F \| 'NF!=12{print}'
p5-IO-Socket-INET6-2.72nb2|net/p5-IO-Socket-INET6|/usr/pkg|Perl object interface for AF_INET|AF_INET6 domain sockets|net/p5-IO-Socket-INET6/DESCR|pkgsrc-users%NetBSD.org@localhost|net perl5|p5-Socket6>=0.12 perl>=5.24.0 cwrappers>=20150314 perl<5.26.0|p5-Socket6>=0.12 perl>=5.24.0 perl<5.26.0|any|any|http://search.cpan.org/dist/IO-Socket-INET6/

Note that COMMENT is "Perl object interface for AF_INET|AF_INET6 domain sockets" and | symbol breaks index formatting acting as separator.

2. security/py-pbkdf2 COMMENT is not stored in index correctly

% grep security/py-pbkdf2 INDEX
py27-pbkdf2-1.3|security/py-pbkdf2|/usr/pkg|"PKCS|security/py-pbkdf2/DESCR|pkgsrc-users%NetBSD.org@localhost|security|py27-setuptools>=0.8 py27-expat-[0-9]* python27>=2.7 mozilla-rootcerts>=1.0.20150804nb1 cwrappers>=20150314 libffi>=1.20 libffi>=3.0.11 readline>=2.2 readline>=6.0 python27>=2.7.1nb2|py27-setuptools>=0.8 py27-expat-[0-9]* python27>=2.7 mozilla-rootcerts>=1.0.20150804nb1 libffi>=1.20 libffi>=3.0.11 python27>=2.7.1nb2|any|any|https://pypi.python.org/pypi/pbkdf2

Note "PKCS in comment field, instead of "PKCS#5 v2.0 PBKDF2 Module"

>How-To-Repeat:
Try to parse INDEX.
>Fix:
JFYI, FreeBSD uses quoting to properly store comment field in INDEX

https://github.com/freebsd/freebsd-ports/blob/master/Mk/bsd.port.mk#L4281

        ${ECHO_CMD} -n ${COMMENT:Q}; \