pkg/51439: pkgsrc/emacs24 can't bulid on NetBSD-current/i386

[stackfield0trpg%gmail.com@localhost]

>Number:         51439
>Category:       pkg
>Synopsis:       pkgsrc/emacs24 can't bulid on NetBSD-current/i386
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 23 10:40:00 +0000 2016
>Originator:     stackfield
>Release:        NetBSD current 2016/08/20/09:30 UTC and pkgsrc current
>Organization:
>Environment:
NetBSD rainsbase 7.99.35 NetBSD 7.99.35 (GENERIC.201608200930Z) i386
>Description:
NetBSD current on i386 can't build a pkgsrc/emacs24.

the following is an important part of a build error message:
gmake[3]: Leaving directory '/usr/pkgsrc/editors/emacs24/work/emacs-24.5/lisp'
if test "no" = "yes"; then \
  rm -f bootstrap-emacs; \
  ln temacs bootstrap-emacs; \
else \
  ./temacs --batch --load loadup bootstrap || exit 1; \
  test "X" = X ||  -zex emacs; \
  mv -f emacs bootstrap-emacs; \
fi
[1]   Segmentation fault (core dumped) ./temacs --batch...
gmake[2]: *** [Makefile:816: bootstrap-emacs] Error 1
gmake[2]: Leaving directory '/usr/pkgsrc/editors/emacs24/work/emacs-24.5/src'
gmake[1]: *** [Makefile:387: src] Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/editors/emacs24/work/emacs-24.5'

>How-To-Repeat:
cd /usr/pkgsrc/editor/emacs24 && make
>Fix:
Index: hacks.mk
===================================================================
RCS file: /cvsroot/pkgsrc/editors/emacs24/hacks.mk,v
retrieving revision 1.4
diff -r1.4 hacks.mk
17a18,29
> ###
> ### On NetBSD/i386 7.99.35,
> ### gcc, version 5.4, produces an illegal object file from src/gmalloc.c.
> ###
> .  if !empty(MACHINE_PLATFORM:MNetBSD-*-i386)
> .    if !empty(CC_VERSION:Mgcc-5.*)
> PKG_HACKS+=           optimisation
> CFLAGS+=              -fno-optimize-strlen
> .    endif
> .  endif
> 
> 
22c34,35
< .  if !empty(MACHINE_PLATFORM:MNetBSD-*-x86_64)
---
> .  if !empty(MACHINE_PLATFORM:MNetBSD-*-x86_64) || \
>       !empty(MACHINE_PLATFORM:MNetBSD-*-i386)