Re: pkg/51396: pkgsrc-2016Q2 cross/mingw-gcc PLIST mismatch

[Matthew Mondor <mm_lists%pulsar-zone.net@localhost>]

The following reply was made to PR pkg/51396; it has been noted by GNATS.

From: Matthew Mondor <mm_lists%pulsar-zone.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/51396: pkgsrc-2016Q2 cross/mingw-gcc PLIST mismatch
Date: Tue, 9 Aug 2016 04:27:25 -0400

 --MP_/QPLKknDsxercBejy.LYfAWp
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Tue,  9 Aug 2016 07:55:01 +0000 (UTC)
 Thomas Klausner <wiz%NetBSD.org@localhost> wrote:
 
 > The following reply was made to PR pkg/51396; it has been noted by
 > GNATS.
 > 
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > Cc: 
 > Subject: Re: pkg/51396: pkgsrc-2016Q2 cross/mingw-gcc PLIST mismatch
 > Date: Tue, 9 Aug 2016 09:53:56 +0200
 > 
 >  On Mon, Aug 08, 2016 at 11:05:01PM +0000, Matthew Mondor wrote:
 >  >  The following solution makes use of GENERATE_PLIST to dynamically
 >  >  generate a PLIST (idea borrowed from the gcc-aux package)  
 >  
 >  We generally don't like dynamic PLISTs. How about adding a
 >  post-install "${RM} -f ${DESTDIR}${PREFIX}/path/to/files" so that
 > they do not get packaged anywhere?
 
 I don't personally care about the C++ precompiled headers as I only use
 the C part of mingw, but it apparently might accelerate C++ code builds
 when a lot of templates are used.  If we don't want them, the RM route
 seems fine.
 
 Since it appears to be build-time-toolchain dependent on if those
 get generated, we're not sure if more such files will also be generated
 by the build in the future, so some globing might be necessary.
 
 Attached is a tested patch implementing this solution.
 
 
 --MP_/QPLKknDsxercBejy.LYfAWp
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=pkgsrc-2016Q2_cross_mingw-gcc_4.diff
 
 Index: Makefile
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/cross/mingw-gcc/Makefile,v
 retrieving revision 1.6
 diff -u -r1.6 Makefile
 --- Makefile	19 Jun 2016 16:23:59 -0000	1.6
 +++ Makefile	9 Aug 2016 08:22:56 -0000
 @@ -2,7 +2,7 @@
  
  DISTNAME=		mingw-gcc-${DIST_VERSION}
  PKGNAME=		${DISTNAME:S/-${DIST_VERSION}/-${GCC_VERSION}/}
 -PKGREVISION=		1
 +PKGREVISION=		2
  CATEGORIES=		cross
  MASTER_SITES=		${MASTER_SITE_MINGW}
  DISTFILES=		gcc-core-${DIST_VERSION}-src.tar.gz \
 @@ -13,7 +13,7 @@
  HOMEPAGE=		http://mingw.sourceforge.net/
  COMMENT=		GNU C Compiler for win32 cross-development
  
 -USE_TOOLS+=		gmake
 +USE_TOOLS+=		gmake perl
  GNU_CONFIGURE=		yes
  GNU_CONFIGURE_PREFIX=	${PREFIX}/cross
  INFO_FILES=		yes
 @@ -42,6 +42,8 @@
  	cd ${DESTDIR}${PREFIX}/cross && ${LN} -fs bin/${MINGW_TARGET}-gcc ${MINGW_TARGET}/bin/gcc
  	cd ${DESTDIR}${PREFIX}/cross && ${LN} -fs bin/${MINGW_TARGET}-c++ ${MINGW_TARGET}/bin/c++
  	cd ${DESTDIR}${PREFIX}/cross && ${LN} -fs bin/${MINGW_TARGET}-g++ ${MINGW_TARGET}/bin/g++
 +	# Remove any potentially built C++ precompiled header files (depends on toolchain used)
 +	${RM} -f ${DESTDIR}${PREFIX}/cross/include/c++/${GCC_VERSION}/i386--mingw32/bits/stdc++.h.gch/*.gch
  
  .include "../../cross/mingw/Makefile.common"
  .include "../../cross/mingw-binutils/buildlink3.mk"
 
 --MP_/QPLKknDsxercBejy.LYfAWp--