Re: pkg/50256: graphics/libepoxy broken on Solaris, again

[Tobias Nygren <tnn%NetBSD.org@localhost>]

The following reply was made to PR pkg/50256; it has been noted by GNATS.

From: Tobias Nygren <tnn%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/50256: graphics/libepoxy broken on Solaris, again
Date: Fri, 18 Sep 2015 18:06:30 +0200

 On Fri, 18 Sep 2015 13:45:01 +0000 (UTC)
 joern.clausen%uni-bielefeld.de@localhost wrote:
 
 > dispatch_common.c: In function 'epoxy_get_proc_address':
 > dispatch_common.c:676:1: error: control reaches end of non-void function [-Werror=return-type]
 >  }
 >  ^
 > 
 > I don't understand when and how this problem was introduced, I was able to build version 1.3.1 of libepoxy a few days ago, and the recent Darwin-related changes look unsuspicious.
 
 You may have been using a different version of MesaLib and updated it
 meanwhile? Looks like the function ends in errx(). I guess is not
 declared __attribute__((__noreturn__)). Does this work?
 
 @@ -672,6 +672,7 @@ epoxy_get_proc_address(const char *name)
  #endif
      }
      errx(1, "Couldn't find current GLX or EGL context.\n");
 +    return NULL; /* NOTREACHED */
  #endif
  }