Re: pkg/50075 (Making dbus actually work on FreeBSD, DragonFly, and probably more)

[David Shao <davshao%gmail.com@localhost>]

The following reply was made to PR pkg/50075; it has been noted by GNATS.

From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50075 (Making dbus actually work on FreeBSD, DragonFly, and
 probably more)
Date: Mon, 7 Sep 2015 18:07:00 -0700

 The following patches enable the dbus daemon to even be started from
 /etc/rc.conf on DragonFly 4.3-DEVELOPMENT and at least recent FreeBSD,
 because the daemon is started using
 
 dbus_enable="YES"
 
 and not
 
 dbus="YES"
 
 An option enable-in-rcvar may be useful for other daemons on DragonFly
 and FreeBSD.
 
 
 diff -Nurb dbus.configure/files/dbus.sh dbus.rcvar/files/dbus.sh
 --- dbus.configure/files/dbus.sh    2008-10-11 12:58:24.000000000 -0700
 +++ dbus.rcvar/files/dbus.sh    2015-09-07 16:39:16.527612000 -0700
 @@ -9,7 +9,7 @@
  . /etc/rc.subr
 
  name="dbus"
 -rcvar=$name
 +rcvar="@DBUS_RCVAR@"
  command="@PREFIX@/bin/dbus-daemon"
  command_args="--system"
  pidfile="@VARBASE@/run/dbus/pid"
 diff -Nurb dbus.configure/options.mk dbus.rcvar/options.mk
 --- dbus.configure/options.mk    2015-09-07 15:57:18.857258000 -0700
 +++ dbus.rcvar/options.mk    2015-09-07 17:16:36.756745000 -0700
 @@ -1,9 +1,13 @@
  # $NetBSD: options.mk,v 1.8 2015/01/21 13:45:18 pho Exp $
 
  PKG_OPTIONS_VAR=    PKG_OPTIONS.dbus
 -PKG_SUPPORTED_OPTIONS+=    debug x11
 +PKG_SUPPORTED_OPTIONS+=    debug x11 enable-in-rcvar
  PKG_SUGGESTED_OPTIONS=    x11
 
 +.if ${OPSYS} == "FreeBSD" || ${OPSYS} == "DragonFly"
 +PKG_SUGGESTED_OPTIONS+= enable-in-rcvar
 +.endif
 +
  .if (${OPSYS} == "NetBSD"  ||    \
       ${OPSYS} == "FreeBSD" ||    \
       ${OPSYS} == "OpenBSD" ||    \
 @@ -52,3 +56,12 @@
  .else
  CONFIGURE_ARGS+=        --disable-launchd
  .endif
 +
 +
 +.if !empty(PKG_OPTIONS:Menable-in-rcvar)
 +DBUS_RCVAR=        dbus_enable
 +.else
 +DBUS_RCVAR=        dbus
 +.endif
 +
 +FILES_SUBST+=        DBUS_RCVAR=${DBUS_RCVAR}
 
 --- options.description.orig    2015-09-07 06:15:43.524230000 -0700
 +++ options.description    2015-09-07 17:13:09.809320000 -0700
 @@ -156,6 +156,7 @@
  elinks-root-exec    Allow elinks to run as root.
  emacs-w3m        W3m browser extention.
  embedded-server        Enable embedded server support for MySQL.
 +enable-in-rcvar        Daemon started in rc.conf by ${daemon}_enable="YES"
  enchant            Add spell checking support using enchant.
  enchant-zemberek    Add spell checking support for Turkish.
  epoll            Enable support for epoll I/O event notification facility.