Re: PR/49852 CVS commit: pkgsrc/net/socat

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/49852; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
Date: Sun, 26 Apr 2015 20:17:49 +0200

 On Sun, Apr 26, 2015 at 05:35:00PM +0000, David Holland wrote:
 > The following reply was made to PR pkg/49852; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-pbugs%netbsd.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
 > Date: Sun, 26 Apr 2015 17:32:25 +0000
 > 
 >  On Sun, Apr 26, 2015 at 11:20:01AM +0000, Joerg Sonnenberger wrote:
 >   >  >  Modified Files:
 >   >  >  	pkgsrc/net/socat: Makefile
 >   >  >  
 >   >  >  Log Message:
 >   >  >  Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.
 >   >  >  
 >   >  >  (XXX: shouldn't the wrappers be taking care of -Werror for compilers
 >   >  >  that don't understand it?)
 >   >  
 >   >  I've removed it. It shouldn't have been added in first place. You are
 >   >  right that just dropping it or translating it into whatever flag the
 >   >  compiler has is a much better approach.
 >  
 >  Someone added it because it was breaking *something*; maybe it would
 >  have been a good idea to find out what and sort it out before
 >  rebreaking the package. :-p
 
 Setting ONLY_FOR_COMPILER is not really going to fix that something, at
 best it will hide the issue behind "this is not supported".
 
 Joerg