Re: pkg/49802: archivers/pigz won't build on Solaris

[Richard PALO <richard%netbsd.org@localhost>]

The following reply was made to PR pkg/49802; it has been noted by GNATS.

From: Richard PALO <richard%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/49802: archivers/pigz won't build on Solaris
Date: Tue, 31 Mar 2015 08:07:16 +0200

 Le 31/03/15 03:15, bnjf+netbsd%bnjf.id.au@localhost a écrit :
 >> Number:         49802
 >> Category:       pkg
 >> Synopsis:       archivers/pigz won't build on Solaris
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       low
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Tue Mar 31 01:15:00 +0000 2015
 >> Originator:     Brad Forschinger
 >> Release:        2014Q4
 >> Organization:
 >> Environment:
 > SunOS x 5.10 Generic_Virtual sun4u sparc SUNW,SPARC-Enterprise
 > cc: Sun C 5.12 SunOS_sparc Patch 148917-08 2014/09/10
 >> Description:
 > 
 > cc -O3 -Wall -Wextra -I/usr/include  -c -o yarn.o yarn.c
 > "/usr/include/sys/feature_tests.h", line 337: #error: "Compiler or options invalid for pre-UNIX 03 X/Open applications  and pre-2001 POSIX applications"
 > 
 >> How-To-Repeat:
 > 
 >> Fix:
 > 
 > --- yarn.c.orig Tue Mar 31 12:10:39 2015
 > +++ yarn.c      Tue Mar 31 12:11:25 2015
 > @@ -22,8 +22,10 @@
 >   */
 >  
 >  /* for thread portability */
 > +#ifndef __sun
 >  #define _XOPEN_SOURCE 700
 >  #define _POSIX_C_SOURCE 200809L
 > +#endif
 >  #define _THREAD_SAFE
 >  
 >  /* use large file functions if available */
 > 
 > 
 This compiles (for me) just fine with gcc on Illumos,
 perhaps because of
 > commit 2d08521bd15501c8370ba2153b9cca4f094979d0
 > Author: Garrett D'Amore <garrett%damore.org@localhost>
 > Date:   Sun May 18 20:08:38 2014 -0700
 > 
 >     2964 need POSIX 2008 locale object support
 >     Reviewed by: Robert Mustacchi <rm%joyent.com@localhost>
 >     Reviewed by: Gordon Ross <gordon.ross%nexenta.com@localhost>
 >     Approved by: Dan McDonald <danmcd%omniti.com@localhost>
 
 which added _XPG7 support in feature_tests.h via
 a _POSIX_C_SOURCE check for 200809L.
 
 Perhaps you should ensure keeping at least XPG6 if your platform
 doesn't support XPG7 yet. 
 
 -- 
 Richard PALO