pkg/49703: nagios-plugins build broken in FreeBSD

[diro%nixsyspaus.org@localhost]

>Number:         49703
>Category:       pkg
>Synopsis:       nagios-plugins build broken in FreeBSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 27 18:40:00 +0000 2015
>Originator:     diro%nixsyspaus.org@localhost
>Release:        FreeBSD 10.1
>Organization:
>Environment:
System: NetBSD asche 5.0.2 NetBSD 5.0.2 (ASCHE.MP) #0: Sun May  2 07:50:23 UTC 2010  root@asche:/usr/obj/sys/arch/alpha/compile/ASCHE.MP alpha
Architecture: amd64
Machine: amd64
>Description:
This isn't breaking news or anything, since we've all seen the bulk build
reports on FreeBSD. Build is failing, because statvfs doesn't have
f_fstypename on FreeBSD.
>How-To-Repeat:
Build nagios-plugins on FreeBSD.
>Fix:
Here's a crappy patch to patch-ak to make the build continue:


$NetBSD: patch-ak,v 1.4 2011/04/08 22:56:12 morr Exp $

--- gl/mountlist.c.orig	2010-07-27 20:47:15.000000000 +0000
+++ gl/mountlist.c
@@ -52,7 +52,11 @@
 # if HAVE_STRUCT_FSSTAT_F_FSTYPENAME
 #  define FS_TYPE(Ent) ((Ent).f_fstypename)
 # else
-#  define FS_TYPE(Ent) mnt_names[(Ent).f_type]
+#  ifdef STAT_STATVFS
+#   define FS_TYPE(Ent) mnt_names[(Ent).f_fsid]
+#  else
+#   define FS_TYPE(Ent) mnt_names[(Ent).f_type]
+#  endif
 # endif
 #endif /* MOUNTED_GETFSSTAT */
 
@@ -99,6 +103,10 @@
 # include <sys/statfs.h>
 #endif
 
+#ifdef HAVE_SYS_STATVFS_H
+#include <sys/statvfs.h>
+#endif
+
 #ifdef MOUNTED_LISTMNTENT
 # include <mntent.h>
 #endif
@@ -169,7 +177,7 @@
 
 #if MOUNTED_GETMNTINFO
 
-# if ! HAVE_STRUCT_STATFS_F_FSTYPENAME
+# if ! HAVE_STRUCT_STATFS_F_FSTYPENAME && ! STAT_STATVFS
 static char *
 fstype_to_string (short int t)
 {
@@ -266,9 +274,13 @@ fstype_to_string (short int t)
 # endif
 
 static char *
+#if defined(STAT_STATVFS) && !defined(__FreeBSD__)
+fsp_to_string (const struct statvfs *fsp)
+#else
 fsp_to_string (const struct statfs *fsp)
+#endif
 {
-# if HAVE_STRUCT_STATFS_F_FSTYPENAME
+# if defined HAVE_STRUCT_STATFS_F_FSTYPENAME || defined STAT_STATVFS
   return (char *) (fsp->f_fstypename);
 # else
   return fstype_to_string (fsp->f_type);
@@ -592,9 +604,17 @@ read_file_system_list (bool need_fs_type
   {
     int numsys, counter;
     size_t bufsize;
+#if defined(STAT_STATVFS) && !defined(__FreeBSD__)
+    struct statvfs *stats;
+#else
     struct statfs *stats;
+#endif
 
+#ifdef STAT_STATVFS
+    numsys = getfsstat ((struct statvfs *)0, 0L, MNT_NOWAIT);
+#else
     numsys = getfsstat ((struct statfs *)0, 0L, MNT_NOWAIT);
+#endif
     if (numsys < 0)
       return (NULL);
     if (SIZE_MAX / sizeof *stats <= numsys)