pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/49702: Allow multimedia/mpv to be used on OSX with Cocoa instead of X11



>Number:         49702
>Category:       pkg
>Synopsis:       Allow multimedia/mpv to be used on OSX with Cocoa instead of X11
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 26 22:55:00 +0000 2015
>Originator:     Jonathan Buschmann
>Release:        
>Organization:
>Environment:
>Description:
Hello,

Currently the package multimedia/mpv require X11 but on OSX (Darwin) it's possible to build against the Cocoa framework, you also get the benefit of a better visual integration.

The patch below remove the dependencies for this package on OSX, I'm not sure if it's the right approach or if it would be better to provide an option 'cocoa' in options.mk

Anyway with this patch the package compile and runs correctly on my system. 
>How-To-Repeat:

>Fix:
diff --git a/multimedia/mpv/Makefile b/multimedia/mpv/Makefile
index 495155f..a9ac4e6 100644
--- a/multimedia/mpv/Makefile
+++ b/multimedia/mpv/Makefile
@@ -32,20 +32,25 @@ SUBST_MESSAGE.audio=        Fixing path to audio device.
 post-install:
        cd ${DESTDIR}${PREFIX} && ${MV} etc/mpv/encoding-profiles.conf share/examples/mpv
 
+.include "../../mk/bsd.prefs.mk"
+
 .include "options.mk"
+
+.if ${OPSYS} != "Darwin"
+.include "../../graphics/MesaLib/buildlink3.mk"
+.include "../../x11/libXinerama/buildlink3.mk"
+.include "../../x11/libXxf86vm/buildlink3.mk"
+.include "../../x11/libXv/buildlink3.mk"
+.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
+.include "../../sysutils/desktop-file-utils/desktopdb.mk"
+.include "../../mk/oss.buildlink3.mk"
+.endif
 .include "../../devel/waf/waf.mk"
 .include "../../devel/zlib/buildlink3.mk"
-.include "../../graphics/MesaLib/buildlink3.mk"
 .include "../../lang/python/application.mk"
 .include "../../multimedia/libass/buildlink3.mk"
 .include "../../multimedia/libdvdnav/buildlink3.mk"
 .include "../../multimedia/libdvdread/buildlink3.mk"
-.include "../../x11/libXinerama/buildlink3.mk"
-.include "../../x11/libXxf86vm/buildlink3.mk"
-.include "../../x11/libXv/buildlink3.mk"
 .include "../../multimedia/ffmpeg2/buildlink3.mk"
-.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
-.include "../../sysutils/desktop-file-utils/desktopdb.mk"
 .include "../../mk/jpeg.buildlink3.mk"
-.include "../../mk/oss.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"



Home | Main Index | Thread Index | Old Index