pkg/49453: lang/gcc45 doesn't build for powerpc

[frank%phoenix.owl.de@localhost]

>Number:         49453
>Category:       pkg
>Synopsis:       lang/gcc45 doesn't build for powerpc
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 06 16:35:00 +0000 2014
>Originator:     Frank Wille
>Release:        pkgsrc-2014Q3
>Organization:
>Environment:
NetBSD jaana.owl.de 5.2_STABLE NetBSD 5.2_STABLE (JAANA) #0: Sun Oct 26 18:47:18 CET 2014  frank@tethys:/home/frank/netbsd/5/src/objmacppc/sys/arch/macppc/compile/JAANA macppc
>Description:
The macro SVR4_ASM_SPEC is undefined in gcc-4.5.3/gcc/config/rs6000/sysv4.h. Compiling gcc.c runs into an error:

(SHLIB_LINK='/usr/pkgsrc/lang/gcc45/work/obj/./gcc/xgcc -B/usr/pkgsrc/lang/gcc45/work/obj/./gcc/ -O2  -g -O2 -I/usr/pkgsrc/lang/gcc45/work/.buildlink/include -I/usr/pkg/include -I/usr/include -DIN_GCC   -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem ./include  -fPIC -g -DHAVE_GTHR_DEFAULT -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED  -shared -nodefaultlibs -Wl,--soname=@shlib_base_name@.so.1 -Wl,--version-script=@shlib_map_file@ -o @multilib_dir@/@shlib_base_name@.so.1.tmp @multilib_flags@ @shlib_objs@ -lc && rm -f @multilib_dir@/@shlib_base_name@.so && if [ -f @multilib_dir@/@shlib_base_name@.so.1 ]; then mv -f @multilib_dir@/@shlib_base_name@.so.1 @multilib_dir@/@shlib_base_name@.so.1.backup; else true; fi && mv @multilib_dir@/@shlib_base_name@.so.1.tmp @multilib_dir@/@shlib_base_name@.so.1 && ln -s @shlib_base_name@.so.1 @multilib_dir@/@shlib_base_name@.so'; \
cc  -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wmissing-format-attribute -Wold-style-definition -Wc++-compat -fno-common  -DHAVE_CONFIG_H -I. -I. -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/. -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/../include -I./../intl -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/../libcpp/include -I/usr/pkg/include -I/usr/pkg/include -I/usr/pkg/include  -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/../libdecnumber -I/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/../libdecnumber/dpd -I../libdecnumber   -I/usr/pkg/include -I/usr/pkg/include/libelf -I/usr/pkgsrc/lang/gcc45/work/.buildlink/include -I/usr/pkg/include -I/usr/include \
  -DLINK_LIBGCC_SPEC="\"%D -R/usr/pkg/gcc45/lib\"" -DSTANDARD_STARTFILE_PREFIX=\"../../../\" -DSTANDARD_EXEC_PREFIX=\"/usr/pkg/gcc45/lib/gcc/\" -DSTANDARD_LIBEXEC_PREFIX=\"/usr/pkg/gcc45/libexec/gcc/\" -DDEFAULT_TARGET_VERSION=\"4.5.3\" -DDEFAULT_TARGET_MACHINE=\"powerpc-unknown-netbsd5.2.\" -DSTANDARD_BINDIR_PREFIX=\"/usr/pkg/gcc45/bin/\" -DTOOLDIR_BASE_PREFIX=\"../../../../\"  `test "X${SHLIB_LINK}" = "X" || test "yes" != "yes" || echo "-DENABLE_SHARED_LIBGCC"` -DCONFIGURE_SPECS="\"\"" \
  -c /usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/gcc.c -o gcc.o)
/usr/pkgsrc/lang/gcc45/work/gcc-4.5.3/gcc/gcc.c:829: error: expected ',' or ';' before 'SVR4_ASM_SPEC'
Makefile:2143: recipe for target 'gcc.o' failed
gmake[3]: *** [gcc.o] Error 1
gmake[3]: Leaving directory '/usr/pkgsrc/lang/gcc45/work/obj/gcc'
Makefile:5274: recipe for target 'all-stage1-gcc' failed

>How-To-Repeat:
# cd /usr/pkgsrc/lang/gcc45
# make

>Fix:
svr4.h is missing in tm_file for powerpc-*-netbsd*. Patch:

--- gcc-4.5.3/gcc/config.gcc.orig       2014-12-06 16:56:26.000000000 +0100
+++ gcc-4.5.3/gcc/config.gcc    2014-12-06 16:57:41.000000000 +0100
@@ -1984,7 +1984,7 @@
        extra_options="${extra_options} rs6000/sysv4.opt"
        ;;
 powerpc-*-netbsd*)
-       tm_file="${tm_file} dbxelf.h elfos.h netbsd.h netbsd-elf.h freebsd-spec.h rs6000/sysv4.h rs6000/netbsd.h"
+       tm_file="${tm_file} dbxelf.h elfos.h netbsd.h netbsd-elf.h svr4.h freebsd-spec.h rs6000/sysv4.h rs6000/netbsd.h"
        tmake_file="${tmake_file} rs6000/t-netbsd"
        extra_options="${extra_options} rs6000/sysv4.opt"
        ;;