pkg/49394: Declare MACOSX_DEPLOYMENT_TARGET for OS X 10.5 to 10.3

[venture37%geeklan.co.uk@localhost]

>Number:         49394
>Category:       pkg
>Synopsis:       Declare MACOSX_DEPLOYMENT_TARGET for OS X 10.5 to 10.3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 15 02:20:00 +0000 2014
>Originator:     Sevan Janiyan
>Release:        pkgsrc-current
>Organization:
>Environment:
Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
Versions of OS X 10.5 and prior which shipped with GCC as main compiler require MACOSX_DEPLOYMENT_TARGET to be declared otherwise a default value of 10.1 is assumed and build fails.
Attached patch declares this variable for 10.3 to 10.5 & skips it otherwise.

Previously MACOSX_DEPLOYMENT_TARGET would need to be declared or build would fail, confirmed lang/perl5 builds without this variable being manually declared.
>How-To-Repeat:

>Fix:
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/lang/perl5/distinfo,v
retrieving revision 1.124
diff -u -r1.124 distinfo
--- distinfo	1 Oct 2014 07:17:02 -0000	1.124
+++ distinfo	15 Nov 2014 02:12:23 -0000
@@ -18,7 +18,7 @@
 SHA1 (patch-dist_Data-Dumper_Dumper.xs) = 2e3384973a70b46f8f9ed72c0e9966e00fcbd8af
 SHA1 (patch-ext_Errno_Errno__pm.PL) = 4f135e267da17de38f8f1e7e03d5209bfd09a323
 SHA1 (patch-hints_cygwin.sh) = 1b21d927d6b7379754c4cd64a2b05d3632c35470
-SHA1 (patch-hints_darwin.sh) = c561d1862f8ca76652a35741c691394eb8cda70a
+SHA1 (patch-hints_darwin.sh) = 15596f109f317ffb14c695b4196bb37699d2f34b
 SHA1 (patch-hints_netbsd.sh) = 16a8b649e23b1d03f4756ec283da44cc08ea9a6b
 SHA1 (patch-hints_sco.sh) = 8d43cdc0632799e1cdb5dc6fdb968052a9ae4216
 SHA1 (patch-install__lib.pl) = 31e9e0fc34386542dd6a60bf6ca0a607babbd4b6
Index: patches/patch-hints_darwin.sh
===================================================================
RCS file: /cvsroot/pkgsrc/lang/perl5/patches/patch-hints_darwin.sh,v
retrieving revision 1.4
diff -u -r1.4 patch-hints_darwin.sh
--- patches/patch-hints_darwin.sh	18 Jul 2013 07:21:02 -0000	1.4
+++ patches/patch-hints_darwin.sh	15 Nov 2014 02:12:23 -0000
@@ -1,17 +1,25 @@
-$NetBSD: patch-hints_darwin.sh,v 1.4 2013/07/18 07:21:02 adam Exp $
+$NetBSD$
 
-Don't set MACOSX_DEPLOYMENT_TARGET.
+MACOSX_DEVELOPMENT_TARGET is required on version of OS X pre 10.6
+See Perl bug #117433
 
---- hints/darwin.sh.orig	2013-05-07 14:45:09.000000000 +0000
+--- hints/darwin.sh.orig	2014-09-14 11:31:02.000000000 +0000
 +++ hints/darwin.sh
-@@ -183,10 +183,6 @@ case "$osvers" in
+@@ -185,13 +185,16 @@ case "$osvers" in
+    ldflags="${ldflags} -flat_namespace"
+    lddlflags="${ldflags} -bundle -undefined suppress"
     ;;
- *) 
+-*) 
++[7-9].*)
     lddlflags="${ldflags} -bundle -undefined dynamic_lookup"
--   case "$ld" in
--       *MACOSX_DEVELOPMENT_TARGET*) ;;
--       *) ld="env MACOSX_DEPLOYMENT_TARGET=10.3 ${ld}" ;;
--   esac
+    case "$ld" in
+        *MACOSX_DEVELOPMENT_TARGET*) ;;
+        *) ld="env MACOSX_DEPLOYMENT_TARGET=10.3 ${ld}" ;;
+    esac
     ;;
++*)
++   lddlflags="${ldflags} -bundle -undefined dynamic_lookup"
++   ;;
  esac
  ldlibpthname='DYLD_LIBRARY_PATH';
+