Re: pkg/47132 (MPlayer crashes (VLC is affected potentially too))

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

The following reply was made to PR pkg/47132; it has been noted by GNATS.

From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/47132 (MPlayer crashes (VLC is affected potentially too))
Date: Wed, 13 Aug 2014 23:26:58 -0500 (CDT)

 Despite claims that GCC >=4.6 does not require the stack-realignment
 options on i386, mplayer built on -7 and -current i386 (GCC 4.8.3)
 crashes in the same fashion as before.
 
 NetBSD slab.technoskunk.fur 7.99.1 NetBSD 7.99.1 (SLAB) #1: Wed Aug 13 
12:15:59 CDT 2014  
sysop%verthandi.technoskunk.fur@localhost:/d0/build/current/obj/i386/sys/arch/i386/compile/SLAB
 i386
 
 Taking a cue from pkg/48680, the following patch produces a working mplayer
 on -7/-current i386:
 
 +Index: multimedia/mplayer-share/Makefile.cflags
 +===================================================================
 +RCS file: /cvsroot/pkgsrc/multimedia/mplayer-share/Makefile.cflags,v
 +retrieving revision 1.6
 +diff -u -p -r1.6 Makefile.cflags
 +--- multimedia/mplayer-share/Makefile.cflags  29 Jun 2013 13:35:04 -0000      
1.6
 ++++ multimedia/mplayer-share/Makefile.cflags  14 Aug 2014 04:21:00 -0000
 +@@ -16,11 +16,11 @@
 + # alignment flags for builtin ffmpeg
 + # --yasm='' disables asm altogether for gcc < 4.2
 + 
 +-.    if !empty(CC_VERSION:Mgcc-4.[2345]*)
 +-CFLAGS+=-mstackrealign -mpreferred-stack-boundary=4
 +-.    elif !empty(CC_VERSION:Mgcc-[123]*) || \
 +-          !empty(CC_VERSION:Mgcc-4.[01]*)
 ++.    if !empty(CC_VERSION:Mgcc-[123]*) || \
 ++        !empty(CC_VERSION:Mgcc-4.[01].*)
 + CONFIGURE_ARGS+=        --yasm=''
 ++.    elif !empty(CC_VERSION:Mgcc-4.*)
 ++CFLAGS+=-mstackrealign -mpreferred-stack-boundary=4
 + .    endif
 + 
 + .    if !empty(CC_VERSION:Mgcc-4*)
 
 
 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645