Re: pkg/48749: www/firefox and www/seamonkey have a NetBSD specific patch

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR pkg/48749; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, schaecsn%gmx.net@localhost
Cc: 
Subject: Re: pkg/48749: www/firefox and www/seamonkey have a NetBSD
 specific patch
Date: Sun, 20 Apr 2014 08:37:59 +0900 (JST)

 From: Stefan Schaeckeler <schaecsn%gmx.net@localhost>, Date: Thu, 17 Apr 2014 
02:00:01 +0000 (UTC)
 
 > The following reply was made to PR pkg/48749; it has been noted by GNATS.
 > 
 > From: Stefan Schaeckeler <schaecsn%gmx.net@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/48749: www/firefox and www/seamonkey have a NetBSD
 >  specific patch
 > Date: Wed, 16 Apr 2014 18:57:13 -0700 (PDT)
 > 
 >  Yes, this diff works for firefox/linux and for seamonkey/linux when applied 
 > to lib/seamonkey/modules/osfile/osfile_unix_allthreads.jsm
 >  
 >  When we are at it, could you also take care of this issue: On Linux, when 
 > using alsa, bmake configure die in:
 >  
 >  configure:21232: checking for alsa
 >  configure:21239: checking MOZ_ALSA_CFLAGS
 >  configure:21244: checking MOZ_ALSA_LIBS
 >  configure:21350: checking for libpulse
 >  configure: error: pulseaudio audio backend requires libpulse development 
 > package
 >  *** Error code 1
 >  
 >  Stop.
 >  bmake: stopped in /usr/pkgsrc/www/firefox
 >  *** Error code 1
 >  
 >  Stop.
 >  
 >  
 >  This is my workaround that made firefox build. Perhaps this should be 
 > better integrated with PKG_OPTIONS pulseaudio
 >  
 >  
 >  --- www/firefox/options.mk.orig 2014-04-12 17:49:45.000000000 -0700
 >  +++ www/firefox/options.mk      2014-04-12 17:50:24.000000000 -0700
 >  @@ -19,12 +19,15 @@
 >   .include "../../mk/bsd.options.mk"
 >   
 >   .if !empty(PKG_OPTIONS:Malsa)
 >  -CONFIGURE_ARGS+=       --enable-alsa
 >  +CONFIGURE_ARGS+=       --enable-alsa --disable-pulseaudio
 >   .include "../../audio/alsa-lib/buildlink3.mk"
 >   .else
 >   CONFIGURE_ARGS+=       --disable-alsa
 >   .endif
 >   
 >  +CONFIGURE_ARGS+=       --disable-gamepad
 >  +
 >  +
 >   .if !empty(PKG_OPTIONS:Mgnome)
 >   .include "../../devel/libgnomeui/buildlink3.mk"
 >   .include "../../sysutils/gnome-vfs/buildlink3.mk"
 >  
 >  
 >  
 >  Similiar issue for seamonkey, except that I even needed to explictly 
 > --enable-alsa and --disable-pulseaudio.
 
 Following patch should work and it is more preferable.
 
 And why --disable-gamepad is needed?
 Do you have another problem under Linux?
 
 Thank you.
 
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/www/firefox/options.mk,v
 retrieving revision 1.19
 diff -u -r1.19 options.mk
 --- options.mk 16 Nov 2013 02:01:46 -0000      1.19
 +++ options.mk 19 Apr 2014 23:36:07 -0000
 @@ -58,6 +58,8 @@
  .if !empty(PKG_OPTIONS:Mpulseaudio)
  .include "../../audio/pulseaudio/buildlink3.mk"
  CONFIGURE_ARGS+=      --enable-pulseaudio
 +.else
 +CONFIGURE_ARGS+=      --disable-pulseaudio
  .endif
  # XXX end
  
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3