Re: pkg/48435: glib-2.38.x doesn't build on Solaris 10

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/48435; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/48435: glib-2.38.x doesn't build on Solaris 10
Date: Mon, 9 Dec 2013 13:34:16 +0100

 On Mon, Dec 09, 2013 at 12:00:01PM +0000, Uwe Klaus wrote:
 >  sorry, did diff in the wrong direction.
 >  
 >  @@ -2699,7 +2699,11 @@ g_local_file_measure_size_of_file (gint 
 >  parent_fd,
 >            return FALSE;
 >  
 >    #ifdef AT_FDCWD
 >  -      dir_fd = openat (parent_fd, name->data, O_RDONLY | O_DIRECTORY);
 >  +#ifdef OPEN_O_DIRECTORY
 >  +      dir_fd = openat (parent_fd, name->data, O_RDONLY|O_DIRECTORY);
 >  +#else
 >  +      dir_fd = openat (parent_fd, name->data, O_RDONLY);
 >  +#endif
 >          if (dir_fd < 0)
 >            return g_local_file_measure_size_error (state->flags, errno, 
 >  name, error);
 >    #endif
 
 Ok, same question: why not just use:
 
    #ifdef AT_FDCWD
  +#ifdef O_DIRECTORY
         dir_fd = openat (parent_fd, name->data, O_RDONLY | O_DIRECTORY);
  +#else
  +      dir_fd = openat (parent_fd, name->data, O_RDONLY);
  +#endif
          if (dir_fd < 0)
 
  Thomas