>Number: 48357
>Category: pkg
>Synopsis: xfe crash when you delete just one file
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Nov 01 08:30:00 +0000 2013
>Originator: Germain Le Chapelain
>Release: latest
>Organization:
>Environment:
NetBSD germ 5.99.65 NetBSD 5.99.65 (GENERIC) #0: Thu Aug 16 12:54:57 UTC 2012
german@germ:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
xfe crash in isEmptyDir at File.cc:494 when you delete files.
>How-To-Repeat:
open xfe.
delete files in a directory.
observe a crash
Program terminated with signal 11, Segmentation fault.
#0 0x00007f7ff628c920 in closedir () from /usr/lib/libc.so.12
(gdb) bt
#0 0x00007f7ff628c920 in closedir () from /usr/lib/libc.so.12
#1 0x00000000004192b8 in isEmptyDir (directory=<optimized out>) at File.cc:494
#2 0x0000000000459701 in FilePanel::onCmdFileDelete (this=0x7f7ff777f1c0) at
FilePanel.cc:1642
#3 0x0000000000466396 in XFileExplorer::onCmdFileDelete (this=<optimized out>,
o=<optimized out>, sel=<optimized out>, ptr=<optimized out>) at
XFileExplorer.cc:2182
#4 0x00007f7ff6fc40a5 in FX::FXObject::tryHandle(FX::FXObject*, unsigned int,
void*) () from /usr/pkg/lib/libFOX-1.6.so.0
#5 0x00007f7ff6f380c2 in FX::FXButton::onLeftBtnRelease(FX::FXObject*,
unsigned int, void*) () from /usr/pkg/lib/libFOX-1.6.so.0
#6 0x00007f7ff6f314ce in FX::FXApp::dispatchEvent(_XEvent&) () from
/usr/pkg/lib/libFOX-1.6.so.0
#7 0x00007f7ff6f30af3 in FX::FXApp::runOneEvent(bool) () from
/usr/pkg/lib/libFOX-1.6.so.0
#8 0x00007f7ff6f30cfb in FX::FXApp::run() () from /usr/pkg/lib/libFOX-1.6.so.0
#9 0x000000000047fbf5 in main (argc=1, argv=<optimized out>) at main.cc:232
>Fix:
bash-4.2# cat /usr/pkgsrc/sysutils/xfe/patches/patch-src_File.cc
$NetBSD$
--- src/File.cc.orig 2013-11-01 01:01:06.000000000 +0000
+++ src/File.cc
@@ -490,8 +490,8 @@ FXint isEmptyDir(const FXString director
ret=1;
else
ret=0;
+ closedir(dir);
}
- closedir(dir);
return ret;
}