Re: pkg/48226: www/firefox link failure (multiple symbol definition) on netbsd-6/i386

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR pkg/48226; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, jdbaker%mylinuxisp.com@localhost
Cc: 
Subject: Re: pkg/48226: www/firefox link failure (multiple symbol
 definition) on netbsd-6/i386
Date: Mon, 23 Sep 2013 21:55:29 +0900 (JST)

 From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>, Date: Mon, 23 Sep 
2013 12:15:01 +0000 (UTC)
 
 > The following reply was made to PR pkg/48226; it has been noted by GNATS.
 > 
 > From: "John D. Baker" <jdbaker%mylinuxisp.com@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/48226: www/firefox link failure (multiple symbol definition)
 >  on netbsd-6/i386
 > Date: Mon, 23 Sep 2013 07:14:35 -0500 (CDT)
 > 
 >  On Mon, 23 Sep 2013, John D. Baker wrote:
 >  
 >  > I have only one machine supporting NetBSD/amd64 (6.1_STABLE).  A build of
 >  > firefox-24.0 is in progress now.  Will advise upon its termination.
 >  
 >  Build on netbsd-6/amd64 succeeded and resulting binary appears to work.
 
 I think xptcinvoke_gcc_x86_unix.o and xptcstubs_gcc_x86_unix.o are
 included twice and the errors occur for i386 (x86).
 The following patch should fix NetBSD/i386 build.
 I have just started build of NetBSD/i386 5.2 and 6.1 with this patch.
 
 $NetBSD: patch-xpcom_reflect_xptcall_src_md_unix_moz.build,v 1.1 2013/09/19 
12:37:50 ryoon Exp $
 
 * Support NetBSD/amd64 and DragonFly/amd64.
 * Integrate NetBSD/i386 configuration.
 
 --- xpcom/reflect/xptcall/src/md/unix/moz.build.orig   2013-09-11 
03:22:57.000000000 +0000
 +++ xpcom/reflect/xptcall/src/md/unix/moz.build
 @@ -19,14 +19,14 @@ if CONFIG['OS_ARCH'] == 'Darwin':
                  'xptcstubs_gcc_x86_unix.cpp',
              ]
  
 -if CONFIG['OS_ARCH'] in ('NetBSD', 'OpenBSD', 'GNU'):
 +if CONFIG['OS_ARCH'] in ('OpenBSD', 'GNU'):
      if CONFIG['CPU_ARCH'] == 'x86':
          CPP_SOURCES += [
              'xptcinvoke_gcc_x86_unix.cpp',
              'xptcstubs_gcc_x86_unix.cpp'
          ]
  
 -if CONFIG['OS_ARCH'] in ('Linux', 'FreeBSD') or \
 +if CONFIG['OS_ARCH'] in ('Linux', 'FreeBSD', 'NetBSD', 'DragonFly') or \
     CONFIG['OS_ARCH'].startswith('GNU_'):
      if CONFIG['OS_TEST'] == 'x86_64':
          CPP_SOURCES += [
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3