pkg/48173: tmux build fails on Solaris10

[stefan.palm%pdmc.net@localhost]

>Number:         48173
>Category:       pkg
>Synopsis:       tmux build fails on Solaris10
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 03 07:05:00 +0000 2013
>Originator:     Stefan Palm
>Release:        2013Q2
>Organization:
>Environment:
SunOS neuwied2 5.10 Generic_147147-26 sun4u sparc64 SUNW,SPARC-Enterprise
>Description:
Build fails due to undefined symbol "timersub":

bmake
=> Bootstrap dependency digest>=20010302: found digest-20121220
===> Checking for vulnerabilities in tmux-1.8nb1
===> Building for tmux-1.8nb1
gcc  -O -I/swmtools/include  -std=gnu99   -O2    -L/swmtools/lib 
-Wl,-R/swmtools/lib -o tmux arguments.o attributes.o  cfg.o client.o clock.o  
cmd-attach-session.o cmd-bind-key.o  cmd-break-pane.o cmd-capture-pane.o  
cmd-choose-buffer.o cmd-choose-client.o  cmd-choose-list.o cmd-choose-tree.o  
cmd-clear-history.o cmd-clock-mode.o  cmd-command-prompt.o cmd-confirm-before.o 
 cmd-copy-mode.o cmd-delete-buffer.o  cmd-detach-client.o cmd-display-message.o 
 cmd-display-panes.o cmd-find-window.o  cmd-has-session.o cmd-if-shell.o  
cmd-join-pane.o cmd-kill-pane.o  cmd-kill-server.o cmd-kill-session.o  
cmd-kill-window.o cmd-link-window.o  cmd-list-buffers.o cmd-list-clients.o  
cmd-list-commands.o cmd-list-keys.o  cmd-list-panes.o cmd-list-sessions.o  
cmd-list-windows.o cmd-list.o  cmd-load-buffer.o cmd-lock-server.o  
cmd-move-window.o cmd-new-session.o  cmd-new-window.o cmd-paste-buffer.o  
cmd-pipe-pane.o cmd-queue.o  cmd-refresh-client.o cmd-rename-session.o  
cmd-rename-window.o cmd-r
 esize-pane.o  cmd-respawn-pane.o cmd-respawn-window.o  cmd-rotate-window.o 
cmd-run-shell.o  cmd-save-buffer.o cmd-select-layout.o  cmd-select-pane.o 
cmd-select-window.o  cmd-send-keys.o cmd-server-info.o  cmd-set-buffer.o 
cmd-set-environment.o  cmd-set-option.o cmd-show-environment.o  
cmd-show-messages.o cmd-show-options.o  cmd-source-file.o cmd-split-window.o  
cmd-start-server.o cmd-string.o  cmd-suspend-client.o cmd-swap-pane.o  
cmd-swap-window.o cmd-switch-client.o  cmd-unbind-key.o cmd-unlink-window.o  
cmd-wait-for.o cmd.o colour.o  control.o control-notify.o environ.o  format.o 
grid-cell.o grid-view.o  grid.o input-keys.o input.o  job.o key-bindings.o 
key-string.o  layout-custom.o layout-set.o layout.o  log.o mode-key.o names.o  
notify.o options-table.o options.o  paste.o resize.o screen-redraw.o  
screen-write.o screen.o  server-client.o server-fn.o  server-window.o server.o 
session.o  signal.o status.o tmux.o  tty-acs.o tty-keys.o tty-term.o  tty.o 
utf8.o window-choose
 .o  window-clock.o window-copy.o window.o  xmalloc.o xterm-keys.o 
osdep-sunos.o forkpty-sunos.o  imsg.o imsg-buffer.o         fgetln.o getopt.o  
strcasestr.o strsep.o vis.o unvis.o  strtonum.o   -lxnet -lsocket -lnsl 
-lcurses -levent -lrt  -lresolv
Undefined                       first referenced
 symbol                             in file
timersub                            server-client.o

ld: fatal: symbol referencing errors. No output written to tmux
collect2: error: ld returned 1 exit status
*** [tmux] Error code 1

bmake: stopped in /tmp/pkgsrc-build/misc/tmux/work/tmux-1.8
1 error

bmake: stopped in /tmp/pkgsrc-build/misc/tmux/work/tmux-1.8
*** Error code 2

Stop.
bmake: stopped in /swm/pkgsrc/source/misc/tmux
*** Error code 1

Stop
>How-To-Repeat:
(Re-) run 'bmake install'.
>Fix:
Adding this to 'server-client.c' fixes the problem:

#ifndef timersub
# define timersub(a, b, result)                     \
    do {                                \
        (result)->tv_sec = (a)->tv_sec - (b)->tv_sec;       \
        (result)->tv_usec = (a)->tv_usec - (b)->tv_usec;        \
        if ((result)->tv_usec < 0) {                            \
            --(result)->tv_sec;             \
            (result)->tv_usec += 1000000;           \
        }                                                       \
    } while (0)
#endif

(Patch found on https://github.com/tony2001/pinba_extension/issues/9 )