On 25/Jul - 11:50, Arnaud Degroote wrote:
> The following reply was made to PR pkg/48083; it has been noted by GNATS.
>
> From: Arnaud Degroote <degroote%netbsd.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc: degroote%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
> pkgsrc-bugs%netbsd.org@localhost,
> szptvlfn%a-net.email.ne.jp@localhost
> Subject: Re: pkg/48083: devel/lua-gi Support to be able to get the file from
> github
> Date: Thu, 25 Jul 2013 13:47:38 +0200
>
> --ZPt4rx8FFjLCG7dd
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On 25/Jul - 11:10, OBATA Akio wrote:
> > The following reply was made to PR pkg/48083; it has been noted by GNATS.
> >=20
> > From: "OBATA Akio" <obache%netbsd.org@localhost>
> > To: gnats-bugs%netbsd.org@localhost
> > Cc:=20
> > Subject: Re: pkg/48083: devel/lua-gi Support to be able to get the file f=
> rom
> > github
> > Date: Thu, 25 Jul 2013 20:07:57 +0900
> >=20
> > > I don't understand -- why is this an improvement?
> > =20
> > Currently, DISTNAME=3D0.7.1, so 0.7.1.tar.gz will be put in ${DISTDIR}.
> > It is unwanted filename (at least, DIST_SUBDIR should be set).
> > Provided filename from https download server is lgi.0.7.1.tar.gz,
> > so it should be used instead.
>
> Yes, you are right. We definitively need curl or wget to download the
> https:// archive. And I don't think about it in the first place but yes,
> 0.7.1.tar.gz is not a good filename for ${DISTDIR}. I will merge your
> patch if no objection from Thomas.
The attached patch should fix the two issues. Is it ok for everyone ?
? work
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/lua-gi/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- Makefile 22 Jul 2013 19:38:07 -0000 1.1
+++ Makefile 25 Jul 2013 11:59:14 -0000
@@ -1,11 +1,11 @@
# $NetBSD: Makefile,v 1.1 2013/07/22 19:38:07 degroote Exp $
#
+DISTNAME= lgi-${VERSION}
PKGNAME= lua-gi-${VERSION}
VERSION= 0.7.1
-DISTNAME= ${VERSION}
-CATEGORIES= devel
-MASTER_SITES= http://github.com/pavouk/lgi/archive/
+CATEGORIES= devel
+MASTER_SITES= -https://codeload.github.com/pavouk/lgi/tar.gz/${VERSION}
MAINTAINER= pkgsrc-users%NetBSD.org@localhost
HOMEPAGE= https://github.com/pavouk/lgi
@@ -14,8 +14,7 @@
USE_LANGUAGES+= c
USE_TOOLS+= pkg-config gmake
-
-WRKSRC= ${WRKDIR}/lgi-${VERSION}
+FETCH_USING= curl
.include "../../devel/glib2/buildlink3.mk"
.include "../../devel/libffi/buildlink3.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/lua-gi/distinfo,v
retrieving revision 1.1
diff -u -r1.1 distinfo
--- distinfo 22 Jul 2013 19:38:07 -0000 1.1
+++ distinfo 25 Jul 2013 11:59:14 -0000
@@ -1,6 +1,6 @@
$NetBSD: distinfo,v 1.1 2013/07/22 19:38:07 degroote Exp $
-SHA1 (0.7.1.tar.gz) = ae1268852b38507c9324e89aa3d950602b5ae8e1
-RMD160 (0.7.1.tar.gz) = 87852dfbc6f3f9944df56324aadbaab6e3b2b802
-Size (0.7.1.tar.gz) = 268327 bytes
+SHA1 (lgi-0.7.1.tar.gz) = ae1268852b38507c9324e89aa3d950602b5ae8e1
+RMD160 (lgi-0.7.1.tar.gz) = 87852dfbc6f3f9944df56324aadbaab6e3b2b802
+Size (lgi-0.7.1.tar.gz) = 268327 bytes
SHA1 (patch-Makefile) = ecba51fb9bc78c08e89bebfc981206a2587e63f4
Attachment:
pgpMnilhKbSLf.pgp
Description: PGP signature