pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/47769 CVS commit: pkgsrc/textproc/ispell-ro

The following reply was made to PR pkg/47769; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
Subject: Re: PR/47769 CVS commit: pkgsrc/textproc/ispell-ro
Date: Tue, 30 Apr 2013 07:36:16 +0700

     Date:        Mon, 29 Apr 2013 17:45:04 +0000 (UTC)
     Message-ID:  <>
   |  There's nothing in there regarding this policy of using DIST_SUBDIR when a
   |  distfile is not versioned in the filename, just when that non-versioned
   |  distfile changes.
 As you pointed out, that's what happened in this case, so the DIST_SUBDIR
 was needed.
   |  If we're going to make this policy, pkglint also needs to
   |  complain when DIST_SUBDIR is not used for a distfile name which contains 
   |  version.
 There's a difference between allowing something, and requiring it.   There
 is no need to have enforceable rules for everything - it is possible that
 there might be a distfile with a name that contains no version, but for
 which the chances of any modifications are vanishingly small (say a historical
 version of some source file, perhaps "original-grep.tgz" or something)
 where use of a DIST_SUBDIR might not be required.   On the other hand, when
 it is quite likely that a distfile will alter, then using a DIST_SUBDIR if
 it has no version in its name makes sense.
 In any case, if a package has a DIST_SUBDIR it is always wrong to remove it
 unless the distfile name changes.

Home | Main Index | Thread Index | Old Index