[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: PR/47605 CVS commit: pkgsrc/net/wpa_supplicant
On Sun, Mar 24, 2013 at 10:39:22PM -0400, rodent%NetBSD.org@localhost wrote:
> > I'm not sure what "pull-up leaf package" means in this case - can you be
> > a bit more specific, please? It doesn't seem to be an internal merging on
> > cvs branches or trunk, so I'm guessing some non-standard usage of terms.
> Right. Perhaps, "updating a package on which no other package depends and
> which already had patches submitted in a PR".
Yes, we're talking a different language then, because a pullup,
especially in relation to the repository, is where a change gets
merged from HEAD/trunk to a branch. So now we have a commit message
which makes no sense unless viewed in an unusual context, and no
pointer to that context.
> > Whatever, please remember that cvs logs need to be able to be parsed in
> > isolation by people using cvs log or via web interface.
> Is there anything more than "PR category/PR_Number" that gets parsed
I'm not talking about automatic parsing, I'm talking about someone
trying to make sense of a change made to the repository. If there's a
problem with this, please run it past me or your mentor in advance,
and we can advise on correct terminology.
> > If you resolve a PR, or a part of a PR, please say exactly what part is
> > resolved - this avoids people having to interface through gnats just to
> > see what has been fixed.
> > And a succinct list of changes between old and new version is needed
> > in the cvs log - please provide this.
> Will do it in subsequent commits.
Which doesn't help anyone viewing the cvs log, either directly on the
command line, or via the web (i.e. because it's a separate email,
there's no reference in the repository).
> [20:07:42] agc@netbsd-vm2 ...pkgsrc/net/wpa_supplicant  > nbcvs log
> RCS file: /cvsroot/pkgsrc/net/wpa_supplicant/Makefile,v
> Working file: Makefile
> head: 1.13
> locks: strict
> access list:
> symbolic names:
> pkgsrc-2012Q4: 18.104.22.168
> pkgsrc-2008Q4-base: 1.2
> pkgsrc-base: 22.214.171.124
> TNF: 1.1.1
> keyword substitution: kv
> total revisions: 14; selected revisions: 14
> revision 1.13
> date: 2013/03/24 14:17:30; author: rodent; state: Exp; lines: +2 -3
> Pull-up leaf package. Half-way resolves PR pkg/47605. OK'd by wiz@ in
> private mail. Diffs were provided in PR.
So I don't know what changed in this version. I don't even know what
this new version is. There's a reference to a PR, so I now have to
rummage through gnats, or, if I'm not connected for some reason, defer
until such time as I am connected.
5 years from now, am I supposed to remember that there was a
qualification dump of changes via email on some mailing list (which
should really be a succinct summary of the changes)?
It would be good to modify the log to reflect these concerns.
Main Index |
Thread Index |