pkg/46708: lang/gcc-aux conditional in buildlink3.mk done incorrectly (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         46708
>Category:       pkg
>Synopsis:       lang/gcc-aux conditional in buildlink3.mk done incorrectly 
>(+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 16 13:15:00 +0000 2012
>Originator:     Robert Elz
>Release:        NetBSD 5.1_STABLE   (pkgsrc current 2012-07-16)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_STABLE NetBSD 5.1_STABLE 
(JADE-1.12-20120130) #27: Tue Jan 31 05:20:31 ICT 2012 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        The conditional added to lang/gcc-ada/buildlink3.mk so that
        gettext-lib isn't unconditionally required was not done
        completely, reaslting in errors from make when the buildlink3.mk
        file gets used from other packages

>How-To-Repeat:
        Try building something that uses it (like www/aws) and expect
        to see stuff like ...

make: "../../lang/gcc-aux/../../lang/gcc-aux/buildlink3.mk" line 16: Malformed 
conditional (!empty(PKG_BUILD_OPTIONS.gcc-aux:Mnls))
make: Fatal errors encountered -- cannot continue

>Fix:
        Apply the following diff (or something like it).
        [This is copied from similar stuff in lang/gcc46, so I am
        assuming it is the way it is supposed to be done].

Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/lang/gcc-aux/buildlink3.mk,v
retrieving revision 1.2
diff -u -r1.2 buildlink3.mk
--- buildlink3.mk       15 Jul 2012 11:50:53 -0000      1.2
+++ buildlink3.mk       16 Jul 2012 13:02:58 -0000
@@ -13,6 +13,9 @@
 .include "../../math/mpfr/buildlink3.mk"
 .include "../../math/mpcomplex/buildlink3.mk"
 
+pkgbase := gcc-aux
+.include "../../mk/pkg-build-options.mk"
+
 .if !empty(PKG_BUILD_OPTIONS.gcc-aux:Mnls)
 .include "../../devel/gettext-lib/buildlink3.mk"
 .endif