Re: pkg/46662: [PATCH] upgrade timidity port to 2.14.0

[Thomas Klausner <tk%giga.or.at@localhost>]

The following reply was made to PR pkg/46662; it has been noted by GNATS.

From: Thomas Klausner <tk%giga.or.at@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/46662: [PATCH] upgrade timidity port to 2.14.0
Date: Sat, 7 Jul 2012 22:43:01 +0200

 --nFreZHaLTZJo0R7j
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hi!
 
 Thanks for the timidity update.
 
 I've tried it on NetBSD-6.99.8/amd64.
 
 I noticed that you removed all CVS ($NetBSD$) tags from the files --
 please don't do that. At least as long as NetBSD's using cvs(1).
 
 I've readded patch-ac because declaring errno as int will break on
 some platforms. I'm not sure about patch-ae, so I've left it removed.
 
 I've also applied the changes you sent separately.
 
 The build failed for me with:
 --- server_c.o ---
 server_c.c: In function 'do_sequencer':
 server_c.c:1251:52: error: 'SEQ_MIDIPUTC' undeclared (first use in this 
function)
 server_c.c:1251:52: note: each undeclared identifier is reported only once for 
each function it appears in
 server_c.c:1257:9: error: 'EV_CHN_VOICE' undeclared (first use in this 
function)
 server_c.c:1262:9: error: 'EV_CHN_COMMON' undeclared (first use in this 
function)
 server_c.c:1267:9: error: 'EV_TIMING' undeclared (first use in this function)
 server_c.c:1272:9: error: 'EV_SYSEX' undeclared (first use in this function)
 server_c.c:1312:13: error: 'MIDI_NOTEON' undeclared (first use in this 
function)
 server_c.c:1325:13: error: 'MIDI_NOTEOFF' undeclared (first use in this 
function)
 server_c.c:1335:13: error: 'MIDI_KEY_PRESSURE' undeclared (first use in this 
function)
 server_c.c:1345:13: error: 'MIDI_CTL_CHANGE' undeclared (first use in this 
function)
 server_c.c:1355:13: error: 'MIDI_PGM_CHANGE' undeclared (first use in this 
function)
 server_c.c:1365:13: error: 'MIDI_CHN_PRESSURE' undeclared (first use in this 
function)
 server_c.c:1375:13: error: 'MIDI_PITCH_BEND' undeclared (first use in this 
function)
 server_c.c:1385:13: error: 'MIDI_SYSTEM_PREFIX' undeclared (first use in this 
function)
 server_c.c:1489:9: error: 'SEQ_FULLSIZE' undeclared (first use in this 
function)
 server_c.c:1496:9: error: 'SEQ_EXTENDED' undeclared (first use in this 
function)
 server_c.c:1502:9: error: 'EV_SEQ_LOCAL' undeclared (first use in this 
function)
 server_c.c:1503:9: error: 'SEQ_PRIVATE' undeclared (first use in this function)
 server_c.c: In function 'do_chn_voice':
 server_c.c:1547:12: error: 'MIDI_NOTEON' undeclared (first use in this 
function)
 server_c.c:1555:12: error: 'MIDI_NOTEOFF' undeclared (first use in this 
function)
 server_c.c:1559:12: error: 'MIDI_KEY_PRESSURE' undeclared (first use in this 
function)
 server_c.c: In function 'do_chn_common':
 server_c.c:1627:12: error: 'MIDI_CTL_CHANGE' undeclared (first use in this 
function)
 server_c.c:1631:12: error: 'MIDI_PGM_CHANGE' undeclared (first use in this 
function)
 server_c.c:1637:12: error: 'MIDI_CHN_PRESSURE' undeclared (first use in this 
function)
 server_c.c:1643:12: error: 'MIDI_PITCH_BEND' undeclared (first use in this 
function)
 server_c.c: In function 'do_timing':
 server_c.c:1660:12: error: 'TMR_START' undeclared (first use in this function)
 server_c.c:1666:12: error: 'TMR_STOP' undeclared (first use in this function)
 server_c.c:1670:12: error: 'TMR_CONTINUE' undeclared (first use in this 
function)
 server_c.c:1679:12: error: 'TMR_TEMPO' undeclared (first use in this function)
 server_c.c:1690:12: error: 'TMR_WAIT_ABS' undeclared (first use in this 
function)
 server_c.c:1703:12: error: 'TMR_WAIT_REL' undeclared (first use in this 
function)
 server_c.c: In function 'do_extended':
 server_c.c:1769:12: error: 'SEQ_CONTROLLER' undeclared (first use in this 
function)
 server_c.c:1772:9: error: 'CTRL_PITCH_BENDER' undeclared (first use in this 
function)
 server_c.c:1774:9: error: 'CTRL_PITCH_BENDER_RANGE' undeclared (first use in 
this function)
 *** [server_c.o] Error code 1
 
 Can you please take a look and recommend a fix?
 
 Thanks,
  Thomas
 
 --nFreZHaLTZJo0R7j
 Content-Type: application/x-tar-gz
 Content-Disposition: attachment; filename="timidity-2.14v2-pkg.tar.gz"
 Content-Transfer-Encoding: base64
 
 H4sIAEWf+E8AA+1ae1PiShaff8mn6FWrZkbJOwF1L7dkIGLu8LBInHGqtopqkg7kGhI2CT5G
 /e57Og8QBZyaHfXu3fxKhHSfRyd9zunTJ93UjEb/3ctCEAWhUlHeCYIgVlWBfguioibfFHJV
 eSeK1aoqV0W1UoV2UaiK4jvhhceVYBbFOETo3ZX7fSPdcOZ6NglfY0ivCdPtuLYb3yA3Qhh1
 9KaO4gB9rX/RkBX4lySMSYhmkeuPUCvEl27EnHlxiKNg5tusFUymOHaHHkHwbY2R43okQkGI
 DNrvBH4cUXEj4pMQxwTZ7siNscfgme0GyMYxRk4YTFArIfBS/YkQDiFzTFISC/toSFAUByGx
 kesjzFAa5ICiaRhYJKLjK1O9Uw/fpDQhAXmxOyEoHofBbDRGICXTSy5di3DMWz/7vwI6mmHU
 W9qL6njO/1VFAv+XFFVWIQTQfhGgFP7/Cqj9OjA7XRJ/MpqHKDOq8iUSOQVJMPu8KPCSjCT5
 UD04VCsInjbSrqdoh2HA0QOIMNRPIQaBP49CPCmjm2D23vPQGF8SGkJcH+YJrgOfoMABWur+
 nhdcgecfMqVdNL0YRaHFJx7OE3yVBCQSPelyQkKg72nHaBblPMyvfCpvPcOb0cEXhAbTl9SR
 +L+y1v8VSa4k639FFCFMqIn/qxWh8P9XwDbKvBY8sakbZrfe0WqlPCvY22MlTlQ4gTn93Eq7
 dm5zskODX9DxsNQmP/l7StvXvuiG3uvWSiLTqJtaq9fXNaNWSlyN6dQNU+sPDN2kbTu3D64H
 Ru+s39COe/2Wdlh7IFQ7N/v1hjkwzo7PayUOJo0bfpcYkKV3Tfho/Vop9WcWgkkYHaW3xQXh
 iDnpdbRTCEi10jiOp4f8fLAc5DGhRSCRGBHOJzHPNHqdjtY1a6UHqRDkEj5MPSRC2LfTFCNk
 2npD6xogcuTP2NHUYy9hMHDng6ZmmE0d7ubs9LTXB0l0OKxNoth2QwYUdI+B14QbL13YZDLz
 aJJiuxie9O5t2R/u3jNMq3s2oIR666wPKko3EJTm14N6v2Xs1UosS3wMuRd7GYODbej3rVkY
 bZQAI4RUbxXBlRuP2WA0qm3t3H4609vNtt79PID7u+dd3/JmNtlay3YZhEM3+hlOzx0et+uN
 n2G1iYPhmbIQy8e1nVs6I8Y3g1JT/g3PIDFN4DB1OvXmt0G3bupfgO6sqffuyzgop/dTdjxs
 laMpIdcMw2XjQVscx8Pf5IIfRjY3DYkTcZOLLUrhoJ3b3ikM4h7Vamir7fqz65XjzwfiRTgi
 /2Y4sDrXYRjj7JNhDhrtumFolLAEiblDbSntyBZbLmutlRrwwx3NQpqzx+nSuvwUuIzTMJf4
 pkGUPDZrnPUf623NWPTbgcU3Fq5jOSNORbTxTzz445QjM+uP00fduSKtuRDDEvQ+KvOzKOS9
 wMIeH41xSOaM5SdzVh69Z5iVs1IrbSMymcY3Kx5z6v5b6O5uud2Y+T3jaXNvSnxKv05RNPNh
 QrzHWo4hm1ipphniUeAfezdrJQZRtEpiZh5rmKhtlNdwNnEI2dBaVjvpnluV1oJnSx2krx3r
 5/fZLJBrPJnC9ms+HYmdppYAxAnT/dIkoyfztdTNMOALrJWZJIFUbecWzOEebUV3R6nuo7v5
 KO620G8gMFH3VNPv6F9MCfi/9j+v0kPNN0sTEzV6Fwy83R4062Y9CR4gOQvO9/mtPKajNKvE
 r2J94PzBNHYDf+7xyzEhyzshavBJEuG5/oWckK6mhOCHgx8mTYPSj5EnQes5UtgdE4/P1oyn
 xKvNFbbrKzVSe6XR/ImczArXxc+LUUL21tnR3x+nbcjmXljHc/t/EXL9PP9XK1Ja/5MqRf7/
 CjiygsmE+PFiGzB0/UX0n2Cfh4+4CIZi3qY+XuvXrCDLYfqt77fAMhL/565F8QV1PLP/F6Tq
 wv/TOCGKslLU/18Dz/g/XbrPRZHH02m+s4rmu/5578MNwGrKIo78RWG7Uez6TvCSOh74P8UT
 /1ekuf9XRUWm/i8ldC85qBy5/4dBEG+i+5v6/6L6Z5zURfThSeUvr7R9RDUk26It7tu2IxNV
 UkTpYF/FzgFWDuwhqWJbVtShUt3H+0y/04Sk7hlpjijZagWLarVyIIvOgVCpSrKgYKdiW86+
 XVFlURWH+5gx3O/kGVki2I4iKWh4E5Mou5WklMFii/arFVKV94lTEWxrX1AEW6oOhypkmRKx
 VSJIBwqMXibK/11cWexcX07HM+s/+Hp1sf6rSf4vQQJQrP+vgIf1f1rH6Z2aeq9rDL7U+7XS
 gwZunhIk1Z60tq018+5aCVJINIovsu5WSzMed6/d7W+snqyuqP4jKft9eDDAww6o+MhsKnJP
 iRWnrxc3UF2FNrONjoMQ0V+PRwPM07FrRfzUHz2uaaQDg9zH9Yn94bz+dWB+O9U+Ml9182QA
 l239Uy0rUl/jK8idavBVho9sl31yHuOreVUvZ05rLGChvo1De+u/FyU/J0S213BeTyc/y5qO
 aBP3fMxpVWj97AA9WlzYvo0WgtiQpK9zWGos7jV9e5BXN/NMdYvW9xbDuGe2N+hy4pXmCKq4
 R1O//ZgMbJHqPHfi1VaywnzBeT5uuHPqW6u0QLu0trpGvIise1MSzGL2Oid96zBU4I2QHXng
 82TpJXQ8t/+vCCqs/6okVhRVUkW6/suiLBXr/ytgfmYnN4DFoR2VFyUeVnXx4FARDsUK+jMg
 4Sg/tsOyLHq6NR9zQeiOSpSbFSVWqFJuWT0UJC6fbQHt0f/M3t7eKgHM0RFiFeWgLAIh/a4i
 aIlvpgRWVmQHM3ra8Ljdq5sD858MYtB2HhR/o2/YA278O7Sy265D6U/qX7SB1u93e4OTh6Qk
 DP2ElN1OAiDid5do0S7PsOQ6JqGPXD9GCX2mbiG4U2+c6F1g6jb1endZwwRbY0gEeCoe+6CK
 qqAnFgcDukkZRFd4Otj98JFqesP5Tw5bLpVWfr2O5/xfEdXs/K9aTc79gf+rUrXw/1fANmqm
 xbq5L6L8ZS2mWTkDyXAc3qSJFT0k7LkXBGWXthtCSu1ekjIazmJwThL572OEh0EYIzc9pZeS
 0pw6lUtl+EEMrjDzbWYhOn8ZnL2Izo/pLVf91pKnB/5+lHpx1K8oKhYoUKBAgQIFChQoUKBA
 gQIFChQoUKBAgQIFChQoUKBAgQIF/ufxH1vNqIwAUAAA
 
 --nFreZHaLTZJo0R7j--