Re: pkg/46586: libXt regression?

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/46586; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/46586: libXt regression?
Date: Tue, 12 Jun 2012 13:42:12 +0200

 On Tue, Jun 12, 2012 at 01:29:13PM +0200, Jörn Clausen wrote:
 > Probably to "restrict". I replaced the macro manually with
 > "__restrict__" and the empty string. Both versions were accepted by
 > the compiler. Only with "restrict" I got the error.
 > 
 > But I have no idea if the definition of X_RESTRICT_KYWD in
 > X11/Xfuncproto.h has to be fixed for GCC 4.7.0, or what else the
 > correct solution would be.
 
 xproto-7.0.23 grew the following lines (compared to the previous 7.0.18):
 > /* C99 keyword "restrict" or equivalent extensions in pre-C99 compilers */
 > /* requires xproto >= 7.0.21 */
 > #ifndef _X_RESTRICT_KYWD
 > # if defined(restrict) /* assume autoconf set it correctly */ || \
 >    (defined(__STDC_VERSION__) && (__STDC_VERSION__ - 0 >= 199901L)) /* C99 */
 > #  define _X_RESTRICT_KYWD  restrict
 > # elif defined(__GNUC__) && !defined(__STRICT_ANSI__) /* gcc 
 > w/C89+extensions */
 > #  define _X_RESTRICT_KYWD __restrict__
 > # else
 > #  define _X_RESTRICT_KYWD
 > # endif
 > #endif
 
 Can you find an appropriate change for these lines that fixes the issue?
 
 Or should we open a bug report with the Xorg people immediately and
 ask them to fix it?
  Thomas