pkg/46390: graphics/feh fails to compile on Linux because PATH_MAX is undeclared

[slitvinov%gmail.com@localhost]

>Number:         46390
>Category:       pkg
>Synopsis:       graphics/feh fails to compile on Linux because PATH_MAX is 
>undeclared
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 30 13:30:01 +0000 2012
>Originator:     Litvinov Sergey
>Release:        Suse Linux
>Organization:
>Environment:
Linux kana 2.6.37.6-0.9-desktop #1 SMP PREEMPT 2011-10-19 22:33:27 +0200 x86_64 
x86_64 x86_64 GNU/Linux
>Description:
graphics/feh fails to compile on Linux with the following error. I
think it related to POSIX/ANSI c headers.

gcc -O2 -Wno-error -std=c99 -I/scratch/netbsd/include -I/usr/include 
-I/scratch/netbsd/include/freetype2 -Wall -Wextra -pedantic -DHAVE_LIBCURL 
-DHAVE_LIBXINERAMA -DPREFIX=\"/scratch/netbsd\" -DPACKAGE=\"feh\" 
-DVERSION=\"2.4\" -Wall -Wextra -pedantic -DHAVE_LIBCURL -DHAVE_LIBXINERAMA 
-DPREFIX=\"/scratch/netbsd\" -DPACKAGE=\"feh\" -DVERSION=\"2.4\" 
-I/scratch/netbsd/include -I/usr/include -I/scratch/netbsd/include/freetype2  
-c -o thumbnail.o thumbnail.c
imlib.c: In function 'feh_magick_load_image':
imlib.c:267:25: error: 'NAME_MAX' undeclared (first use in this function)
imlib.c:267:25: note: each undeclared identifier is reported only once for each 
function it appears in
imlib.c:273:2: warning: implicit declaration of function 'mkstemp'
imlib.c: In function 'feh_http_load_image':
imlib.c:337:25: error: 'NAME_MAX' undeclared (first use in this function)
imlib.c:345:3: warning: implicit declaration of function 'fdopen'
imlib.c:345:7: warning: assignment makes pointer from integer without a cast
imlib.c: In function 'feh_draw_info':
imlib.c:699:2: warning: implicit declaration of function 'popen'
imlib.c:699:12: warning: assignment makes pointer from integer without a cast
imlib.c:723:3: warning: implicit declaration of function 'pclose'
filelist.c: In function 'add_file_to_filelist_recursively':
filelist.c:216:3: warning: implicit declaration of function 'scandir'
filelist.c:216:45: error: 'alphasort' undeclared (first use in this function)
filelist.c:216:45: note: each undeclared identifier is reported only once for 
each function it appears in
filelist.c: In function 'feh_absolute_path':
filelist.c:498:11: error: 'PATH_MAX' undeclared (first use in this function)
filelist.c:516:2: warning: implicit declaration of function 'realpath'
filelist.c:500:7: warning: unused variable 'temp'
filelist.c:499:7: warning: unused variable 'fullpath'
filelist.c:498:7: warning: unused variable 'cwd'
make[1]: *** [imlib.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [filelist.o] Error 1
menu.c: In function 'feh_menu_init_common':
menu.c:1029:7: warning: cast to pointer from integer of different size
menu.c:1032:7: warning: cast to pointer from integer of different size
menu.c:1042:7: warning: cast to pointer from integer of different size
menu.c:1045:7: warning: cast to pointer from integer of different size
menu.c:1054:23: warning: cast to pointer from integer of different size
menu.c:1057:30: warning: cast to pointer from integer of different size
menu.c:1067:7: warning: cast to pointer from integer of different size
menu.c:1071:7: warning: cast to pointer from integer of different size
menu.c: In function 'feh_menu_cb':
menu.c:1259:48: warning: cast from pointer to integer of different size
menu.c:1264:48: warning: cast from pointer to integer of different size
menu.c:1269:48: warning: cast from pointer to integer of different size
menu.c:1274:48: warning: cast from pointer to integer of different size
menu.c:1278:55: warning: cast from pointer to integer of different size
menu.c:1281:55: warning: cast from pointer to integer of different size
menu.c:1284:55: warning: cast from pointer to integer of different size
menu.c:1287:55: warning: cast from pointer to integer of different size
menu.c:1349:32: warning: cast from pointer to integer of different size
options.c: In function 'feh_parse_option_array':
options.c:503:4: warning: implicit declaration of function 'strcasecmp'
signals.c: In function 'setup_signal_handlers':
signals.c:34:19: error: storage size of 'feh_sh' isn't known
signals.c:37:3: warning: implicit declaration of function 'sigemptyset'
signals.c:38:3: warning: implicit declaration of function 'sigaddset'
signals.c:50:3: warning: implicit declaration of function 'sigaction'
signals.c:34:19: warning: unused variable 'feh_sh'
make[1]: *** [signals.o] Error 1
make[1]: Leaving directory `/scratch/src/pkgsrc/graphics/feh/work/feh-2.4/src'
make: *** [build-src] Error 2
*** Error code 2

>How-To-Repeat:
bmake build
in pkgsrc/graphics on Linux
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/feh/Makefile,v
retrieving revision 1.47
diff -u -p -u -r1.47 Makefile
--- Makefile    21 Mar 2012 18:16:18 -0000      1.47
+++ Makefile    30 Apr 2012 13:22:21 -0000
@@ -21,7 +21,10 @@ USE_TOOLS+=  bash:run perl:run gmake
 REPLACE_BASH=          cam/gen-cam-menu
 REPLACE_PERL=          scripts/*.pl cam/feh-cam
 
+.include "../../mk/bsd.prefs.mk"
+.if ${OPSYS} != "Linux"
 CFLAGS+=                       -std=c99
+.endif
 
 LDFLAGS.SunOS+=                -lnsl -lsocket