Re: pkg/46273 (textproc/groff does not compile on Solaris with older compilers)

[Hans Rosenfeld <rosenfeld%grumpf.hope-2000.org@localhost>]

The following reply was made to PR pkg/46273; it has been noted by GNATS.

From: Hans Rosenfeld <rosenfeld%grumpf.hope-2000.org@localhost>
To: Filip Hajny <filip%joyent.com@localhost>
Cc: Tim Zingelman <tez%NetBSD.org@localhost>, gnats-bugs%NetBSD.org@localhost,
        Hans Rosenfeld <hans%NetBSD.org@localhost>, 
solaris-pkg-people%NetBSD.org@localhost,
        pkgsrc-bugs%NetBSD.org@localhost, Thomas Klausner 
<wiz%NetBSD.org@localhost>,
        =?iso-8859-1?Q?J=F6rn?= Clausen 
<joern.clausen%uni-bielefeld.de@localhost>
Subject: Re: pkg/46273 (textproc/groff does not compile on Solaris with older 
compilers)
Date: Sat, 31 Mar 2012 13:45:43 +0200

 On Sat, Mar 31, 2012 at 12:43:01PM +0200, Filip Hajny wrote:
 > On 31. 3. 2012, at 0:03, Tim Zingelman wrote:
 > 
 > > This breaks my compile on Solaris 10, using gcc44 (from pkgsrc) too,
 > > so it is not only gcc 3.x affected.
 > > 
 > > What exactly was this supposed to fix?  I would like to revert it.
 > > You can add it back as an option perhaps?
 > > 
 > > - Tim
 > 
 > I believe it's to fix building with GCC 4.6. g++ 4.6 *forces*
 > __STDC_VERSION__=199901L on SunOS, which is evaluated as _STDC_C99 in
 > sys/feature_tests.h, hence any C++ code that tries to define _XPG<6
 > which trigger an error in sys/feature_tests.h.
 
 Yes, thats the case, and I'm going to make it specific to gcc46.
 
 Hans
 
 -- 
 %SYSTEM-F-ANARCHISM, The operating system has been overthrown