Re: pkg/46269: audio/sox: add compilation options

["Andrey N. Oktyabrski" <ano%bestmx.ru@localhost>]

The following reply was made to PR pkg/46269; it has been noted by GNATS.

From: "Andrey N. Oktyabrski" <ano%bestmx.ru@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46269: audio/sox: add compilation options
Date: Wed, 28 Mar 2012 18:30:49 +0400

 This is a multi-part message in MIME format.
 --------------080908040705090401050601
 Content-Type: text/plain; charset=KOI8-R; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Here is a new patch. It contains more options:
 oss sun alsa libao  lame ffmpeg wavpack opencore-amr id3tag
 
 I have tested compilation with these all options. It happens 
 successfully without errors. This is a good news.
 
 The bad news is: WITHOUT any options sox compiles WITH as many 
 extensions as it can find. For example, it use alsa-lib (installed from 
 OpenIndiana IPS repository or from pkgsrc), ffmpeg, opencore-amr and so 
 on. Really, I can not disable any extension, I can uninstall correspond 
 package - then sox's "configure" script do not compile it in.
 
 Original audio/sox (without my patch) has exactly the same issue.
 
 Is it sox' own problem, or it is autotools disaster? I can't understand.
 
 --------------080908040705090401050601
 Content-Type: text/plain; charset=UTF-8;
  name="sox_pkgsrc.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="sox_pkgsrc.patch"
 
 diff -uwpr sox/options.mk sox.ano/options.mk
 --- sox/options.mk     2010-10-30 19:07:42.000000000 +0400
 +++ sox.ano/options.mk 2012-03-28 18:01:09.522664897 +0400
 @@ -1,18 +1,74 @@
  # $NetBSD: options.mk,v 1.5 2010/10/30 15:07:42 drochner Exp $
  
  PKG_OPTIONS_VAR=      PKG_OPTIONS.sox
 -PKG_SUPPORTED_OPTIONS=        lame oss
 +PKG_SUPPORTED_OPTIONS=        oss sun alsa libao  lame ffmpeg wavpack 
opencore-amr id3tag
  # lame has LICENSE= issues and thus should not be SUGGESTED.
  PKG_SUGGESTED_OPTIONS=
  .include "../../mk/bsd.options.mk"
  
 +### Audio driver options ###
 +.if !empty(PKG_OPTIONS:Moss)
 +.include "../../mk/oss.buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-oss
 +.else
 +CONFIGURE_ARGS+=      --without-oss
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Msun)
 +CONFIGURE_ARGS+=      --with-sunaudio
 +.else
 +CONFIGURE_ARGS+=      --without-sunaudio
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Malsa)
 +.include "../../audio/alsa-lib/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-alsa
 +.else
 +CONFIGURE_ARGS+=      --without-alsa
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mlibao)
 +.include "../../audio/libao/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-ao
 +.else
 +CONFIGURE_ARGS+=      --without-ao
 +.endif
 +
 +### Codec options ###
  .if !empty(PKG_OPTIONS:Mlame)
  # This is an option due to LICENSE= issues.
  .include "../../audio/lame/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-lame
 +.else
 +CONFIGURE_ARGS+=      --without-lame
  .endif
  
 -.if !empty(PKG_OPTIONS:Moss)
 -.include "../../mk/oss.buildlink3.mk"
 +.if !empty(PKG_OPTIONS:Mffmpeg)
 +.include "../../multimedia/ffmpeg/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-ffmpeg
  .else
 -CONFIGURE_ARGS+=      --without-oss
 +CONFIGURE_ARGS+=      --without-ffmpeg
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mwavpack)
 +.include "../../audio/wavpack/buildlink3.mk"
 +.include "../../converters/libiconv/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-wavpack
 +.else
 +CONFIGURE_ARGS+=      --without-wavpack
  .endif
 +
 +.if !empty(PKG_OPTIONS:Mopencore-amr)
 +.include "../../audio/opencore-amr/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-amrnb --with-amrwb
 +.else
 +CONFIGURE_ARGS+=      --without-amrnb --without-amrwb
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mid3tag)
 +.include "../../audio/libid3tag/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-libid3tag
 +.else
 +CONFIGURE_ARGS+=      --without-libid3tag
 +.endif
 +
 
 --------------080908040705090401050601--