Re: pkg/46206

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR pkg/46206; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46206
Date: Tue, 20 Mar 2012 10:22:54 +0100

 This might fix the firefox issue as well,
 
 Can you test?
 
 Thanks,
 
 Martin
 
 ----- Forwarded message from Frank Kardel <kardel%netbsd.org@localhost> -----
 
 X-Original-To: martin%duskware.de@localhost
 Delivered-To: martin%duskware.de@localhost
 Delivered-To: current-users%netbsd.org@localhost
 X-Virus-Scanned: amavisd-new at NetBSD.org
 Date: Tue, 20 Mar 2012 08:39:43 +0100
 From: Frank Kardel <kardel%netbsd.org@localhost>
 User-Agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv:1.9.2.17) 
Gecko/20110716 Lightning/1.0b3pre Lanikai/3.1.10
 To: Sverre Froyen <sverre%viewmark.com@localhost>
 CC: current-users%netbsd.org@localhost
 Subject: Re: ntpq -p coredumps with today's sources
 In-Reply-To: <201203191744.44332.sverre%viewmark.com@localhost>
 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.2.7 
(pip.kardel.name [10.0.3.1]); Tue, 20 Mar 2012 08:39:45 +0100 (CET)
 X-Virus-Scanned: clamav-milter 0.97.3 at pip.kardel.name
 X-Virus-Status: Clean
 List-Id: current-users.NetBSD.org
 
 Could you check this patch.
 
 ntpq.c exercises the new AI_ADDRCONFIG option in getaddrinfo(). There 
 seems to
 be a PNPE (programmed null pointer exception).
 
 Frank
 
 
 On 03/20/12 00:44, Sverre Froyen wrote:
 >Hi,
 >
 >With sources from today (kernel and userland), I get a segmentation fault 
 >from
 >'ntpq -p'. Gdb says
 >
 >Program received signal SIGSEGV, Segmentation fault.
 >0x00007f7ff5cd4b58 in getaddrinfo () from /usr/lib/libc.so.12
 >(gdb) bt
 >#0  0x00007f7ff5cd4b58 in getaddrinfo () from /usr/lib/libc.so.12
 >#1  0x0000000000403f8b in openhost ()
 >#2  0x0000000000406427 in ntpqmain ()
 >#3  0x0000000000403542 in ___start ()
 >#4  0x00007f7ff7c06ae6 in _rtld () from /usr/libexec/ld.elf_so
 >#5  0x00007f7ffffff9d8 in ?? ()
 >#6  0x00007f7ffffff9f7 in ?? ()
 >#7  0x00007f7ffffffa56 in ?? ()
 >#8  0x00007f7ffffffa96 in ?? ()
 >#9  0x00007f7ffffffab6 in ?? ()
 >#10 0x00007f7ffffffac8 in ?? ()
 >#11 0x00007f7ffffffad8 in ?? ()
 >#12 0x00007f7ffffffb0a in ?? ()
 >#13 0x00007f7ffffffb20 in ?? ()
 >...
 >
 >I don't see any other major breakage. Is ntpq using getaddrinfo incorrectly?
 >
 >This is on NetBSD 6.99.4 / amd64.
 >
 >Regards,
 >Sverre
 
 
 Index: getaddrinfo.c
 ===================================================================
 RCS file: /cvsroot/src/lib/libc/net/getaddrinfo.c,v
 retrieving revision 1.98
 diff -u -r1.98 getaddrinfo.c
 --- getaddrinfo.c      17 Mar 2012 21:56:40 -0000      1.98
 +++ getaddrinfo.c      20 Mar 2012 07:35:25 -0000
 @@ -1032,7 +1032,7 @@
        if (getifaddrs(&ifaddrs) == -1)
                return -1;
  
 -      mask = 0;
 +      *mask = 0;
        for (ifa = ifaddrs; ifa != NULL; ifa = ifa->ifa_next)
                if (ifa->ifa_addr && (ifa->ifa_flags & IFF_UP)) {
                        _DIAGASSERT(ifa->ifa_addr->sa_family < 64);
 
 
 ----- End forwarded message -----