Re: pkg/45774 (lang/php53 not using CVS NetBSD ID and wrong checksum for patch-Zend_zend__builtin__functions.c)

["B.ICT A.P. deBROUWER Jr." <noud4%home.nl@localhost>]

On Wed, 2012-01-04 at 03:22 +0000, taca%NetBSD.org@localhost wrote:
> Synopsis: lang/php53 not using CVS NetBSD ID and wrong checksum for 
> patch-Zend_zend__builtin__functions.c
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: taca%NetBSD.org@localhost
> State-Changed-When: Wed, 04 Jan 2012 03:22:24 +0000
> State-Changed-Why:
> Revision 1.28 of pkgsrc/lang/php53/distinfo should be fix the problem.

No, is not okay:


10# cat /root/.cvsrc
cvs -q -z3
checkout -P
update -dP
diff -upN
rdiff -u
release -d
10# rm patches/patch-Zend_zend__builtin__functions.c
10# cvs update -dP
cvs update: warning: patches/patch-Zend_zend__builtin__functions.c was
lost
U patches/patch-Zend_zend__builtin__functions.c
10# head patches/patch-Zend_zend__builtin__functions.c
$NetBSD$ <<<<<<<<<<<<<<<<<<<<< this

having:
10# head -1 distinfo
$NetBSD: distinfo,v 1.28 2012/01/04 02:31:47 taca Exp $

same:
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/php53/patches/
showns version 1.2 for patch-Zend_zend__builtin__functions.c
while
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/php53/patches/patch-Zend_zend__builtin__functions.c
shows version 1.2.2.2
and them both|all show just "$NetBSD$"



The checksum in distinfo is okay now:
=> Applying pkgsrc patches for php-5.3.8nb2
===> Creating toolchain wrappers for php-5.3.8nb2
...
=> Unwrapping files-to-be-installed.


So mind.. is not one thing that was wrong but 2 things!
-the cvs netbsd id in netbsd cvs repository itself (still oddly wrong).
-the checksum generated in distinfo.

Noud
--