pkg/45766: netpbm build fails on IRIX because of missing strdup (again)

[duck+important%shangtai.net@localhost]

>Number:         45766
>Category:       pkg
>Synopsis:       netpbm build fails on IRIX because of missing strdup (again)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 01 13:25:00 +0000 2012
>Originator:     duck+important%shangtai.net@localhost
>Release:        pkgsrc-2011Q3
>Organization:
>Environment:
System: IRIX64 halo 6.5 6.5.29m 01090133 IP30
Architecture: mips
Machine: IP30
>Description:
netpbm fails to build converter/other/cameratopam.c because _XOPEN_SOURCE is
defined, this causes string.h (/usr/include/internal/core_string.h) to skip the
export of strdup()

>How-To-Repeat:
Attempt to build netpbm on IRIX
>Fix:
Don't define _XOPEN_SOURCE on SGI systems, perhaps through modifying 
patches/patch-dd to look like this (the _OSF_SOURCE is harmless):

--- converter/other/cameratopam/cameratopam.c.orig      2006-08-19 
03:12:28.000000000 +0000
+++ converter/other/cameratopam/cameratopam.c
@@ -8,7 +8,11 @@


 #define _BSD_SOURCE 1   /* Make sure string.h contains strcasecmp() */
+#if defined(__osf__) || defined(__sgi)
+#define _OSF_SOURCE
+#else
 #define _XOPEN_SOURCE  /* Make sure unistd.h contains swab() */
+#endif /* __osf__ */

 #include <ctype.h>
 #include <unistd.h>