[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/45047: pkgtools/pkg_install minix support
The following reply was made to PR pkg/45047; it has been noted by GNATS.
From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
Subject: Re: pkg/45047: pkgtools/pkg_install minix support
Date: Fri, 17 Jun 2011 20:19:50 +0200
On Fri, Jun 17, 2011 at 05:55:02PM +0000, Thomas Cort wrote:
> The following reply was made to PR pkg/45047; it has been noted by GNATS.
> From: Thomas Cort <tcort%minix3.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Subject: Re: pkg/45047: pkgtools/pkg_install minix support
> Date: Fri, 17 Jun 2011 13:54:45 -0400
> > > +normalise_version(char *release, char *version)
> > Why aren't the checks here fatal?
> They are, in a way. The function returns an error to check_platform(),
> which returns the error to pkg_do(), which returns the error to
> pkg_perform(), which returns the error to main(), which calls exit(1).
> I chose that method instead of just exiting at the point of the error
> because Alistair suggested returning an error to the calling function...
> > Personally, I don't like to use assertions in production code. We
> > have seen too many failures at inopportune moments from systems like
> > bind for me to believe that it's a good thing. I'd like to replace
> > the assertions with a check, and return a sane error to the calling
> > function.
Assertions are conditionally disabled. That's slightly different. Also
at the time of calling, nothing permanent should have been done.
Main Index |
Thread Index |