[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/45044: archivers/libarchive minix support
The following reply was made to PR pkg/45044; it has been noted by GNATS.
From: Thomas Cort <tcort%minix3.org@localhost>
Subject: Re: pkg/45044: archivers/libarchive minix support
Date: Mon, 13 Jun 2011 14:13:01 -0400
I asked the developer(s) who made the uid/gid overflow detection
changes why exactly the changes were needed. The devs seem to remember
that some of the pkg_* utilities try querying for the username and
segfault when the uid is invalid.
I did some grep-ing and user_from_uid() from
libnbcompat/files/pwcache.c is called in a couple of places in
pkgtools/pkg_install without checking the return value.
user_from_uid() is called with noname=1 which, when a uid without a
corresponding username is passed, returns NULL. I'll investigate this
issue further in the coming days.
So my plan is to take a deeper look at the core issue
(user_from_uid()), fix that problem (create a patch and new PR), and
then see if anything else might require the libarchive change we
> I feel this is a case of "use saner types or just cope".
We'd still like to at least have a warning when a uid or gid is
truncated. Would you accept such a change? If so, I'll create a new
Main Index |
Thread Index |