pkg/45019: misc/colorls fails to build due to warnings with -Werror

[kojiro%hello-channel.com@localhost]

>Number:         45019
>Category:       pkg
>Synopsis:       misc/colorls fails to build due to warnings with -Werror
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 04 01:00:00 +0000 2011
>Originator:     Daniel Loffgren
>Release:        current
>Organization:
>Environment:
NetBSD niigaki 5.99.52 NetBSD 5.99.52 (GENERIC) #0: Thu May 26 17:08:24 UTC 
2011  
builds%b7.netbsd.org@localhost:/home/builds/ab/HEAD/i386/201105261200Z-obj/home/builds/ab/HEAD/src/sys/arch/i386/compile/GENERIC
 i386

>Description:
colorls cannot build because of warnings with -Werror. They are; three missing 
forward declarations, a missing function return type, and an implicit system 
header being used without being included.
>How-To-Repeat:
Try to build the latest colorls package from pkgsrc.
>Fix:
Either remove the -Werror and live with the warnings, or apply my two patches:

--- print.c.orig        2011-06-03 19:19:02.000000000 -0500
+++ print.c     2011-06-03 19:45:04.000000000 -0500
@@ -53,6 +53,7 @@
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
+#include <ctype.h>
 
 #include "ls.h"
 #include "extern.h"
@@ -336,6 +337,7 @@
        printf("m");
 }
 
+int
 colortype(mode)
        mode_t mode;
 {


--- extern.h.orig       2011-06-03 19:43:10.000000000 -0500
+++ extern.h    2011-06-03 19:43:59.000000000 -0500
@@ -49,3 +49,7 @@
 void    printlong __P((DISPLAY *));
 void    printscol __P((DISPLAY *));
 void    usage __P((void));
+
+void   parsecolors(char *);
+int    colortype(mode_t);