[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/44868: update misc/calibre to 0.7.54
The following reply was made to PR pkg/44868; it has been noted by GNATS.
From: Rhialto <rhialto%falu.nl@localhost>
Cc: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
Subject: Re: pkg/44868: update misc/calibre to 0.7.54
Date: Fri, 20 May 2011 16:34:11 +0200
On Fri 20 May 2011 at 11:50:04 +0000, Thomas Klausner wrote:
> I've tried it out. I see the following issues:
> The master sites redirect automatically to 0.8.1; I had to download the
> tarball manually.
I might as well go for the newer version then.
> During installation I see:
> xprop: unable to open display ':0'
> Installing calibre environment module:
> calibre successfully installed. You can start it by running the command
> There were 1 warning(s):
> * Must be run as root to compile mount helper. Auto mounting of devices
> will not work.
Bah, the build is tring to be "clever". You probably didn't build with
"sudo pkg_comp ...", as I did. For that case, the ./setup/__init__.py
script tries to detect if you're running under sudo by looking at some
SUDO_* environment variables. If their presence is detected, it tries to
drop priviledges to that user - which leads to problems in the chroot
because that user doesn't exist.
This probably can't even be fixed by adding
build_env += SUDO_UID= SUDO_GID= SUDO_USER=
because the ``env'' command then adds those variables with empty values,
instead of removing them. Maybe I should just patch that part away.
> ERROR: The following files are in /usr/pkg but not in the PLIST:
> *** Error code 1
> Also, if REPLACE_PYTHON doesn't work as intended, we should improve it
> instead of reimplementing it. The current implementation is in
I looked at mk/configure/replace-interpreter.mk, and claims to handle
REPLACE_PYTHON but doesn't.
It looks like that file should work better, but indeed it doesn't handle
some cases that occur in calibre: One of the shbang lines is as
extreme as ``#!/usr/bin/env python2'': with /usr/bin/env, multiple
spaces, and a version number appended. /.*python[^ ]*/ simply can't
deal with that. Also, such a string occurs in the middle of a script
once, to be edited into installed files.
> Can you please take a look at them?
___ Olaf 'Rhialto' Seibert -- There's no point being grown-up if you
\X/ rhialto/at/xs4all.nl -- can't be childish sometimes. -The 4th Doctor
Main Index |
Thread Index |