pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/44857: Pkgsrc2011Q1/2010Q4: building binary packages and binary packages of dependencies.



The following reply was made to PR pkg/44857; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/44857: Pkgsrc2011Q1/2010Q4: building binary packages and
 binary packages of dependencies.
Date: Tue, 26 Apr 2011 22:02:49 +0900

 On Tue, 12 Apr 2011 08:50:00 +0900, 
<nathanial_sloss%optusnet.com.au@localhost> wrote:
 
 > cd pkgsrc/security/sudo
 >
 > make package
 >
 > Sometimes binaries of dependencies are created (f2c, libtool, etc) sometimes 
 > not.
 >> Fix:
 
 Workaround:
 put DEPENDS_TARGET=package (or pakcage-install) on /etc/mk.conf.
 
 It came from changes of default set to DEPENDS_TARGET in mk/bsd.depends.mk.
 
 with USE_DESTDIR=no (default on pkgsrc-2011Q1 and 2010Q4),
 previously, DEPENDS_TARGET will be set as "package" with "make package",
 but now, set as "package-install".
 So direct dependency will be installed as "make package" (binary package will 
be created),
 but indirect dependency will be istalled as "make ${UPDATE_TARGET}" (usually, 
"make install",
 so binary package will not be created).
 
 How about changes as followings?
 
 
 Index: bsd.pkg.update.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.update.mk,v
 retrieving revision 1.22
 diff -u -r1.22 bsd.pkg.update.mk
 --- bsd.pkg.update.mk   3 Jul 2010 04:24:14 -0000       1.22
 +++ bsd.pkg.update.mk   26 Apr 2011 13:01:09 -0000
 @@ -16,7 +16,7 @@
   #
   .if !defined(UPDATE_TARGET)
   .  if defined(DEPENDS_TARGET) && (${DEPENDS_TARGET} == "update")
 -.    if ${_USE_DESTDIR} != "no" || make(package)
 +.    if ${_USE_DESTDIR} != "no" || make(package) || make(package-install)
   UPDATE_TARGET= package-install
   .    else
   UPDATE_TARGET= install
 Index: depends/bsd.depends.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/depends/bsd.depends.mk,v
 retrieving revision 1.20
 diff -u -r1.20 bsd.depends.mk
 --- depends/bsd.depends.mk      25 Feb 2010 02:06:34 -0000      1.20
 +++ depends/bsd.depends.mk      26 Apr 2011 13:01:09 -0000
 @@ -22,7 +22,7 @@
   # dependencies.  This variable is user-settable in /etc/mk.conf.
   #
   .if !defined(DEPENDS_TARGET)
 -.  if !empty(USE_DESTDIR:M[Yy][Ee][Ss]) || make(package)
 +.  if !empty(USE_DESTDIR:M[Yy][Ee][Ss]) || make(package) || 
make(package-install)
   DEPENDS_TARGET=                package-install
   .  elif make(update)
   .    if defined(UPDATE_TARGET) && (${UPDATE_TARGET} == "replace")
 
 
 -- 
 OBATA Akio / obache%NetBSD.org@localhost
 


Home | Main Index | Thread Index | Old Index